crowdcomms/apistar-aws-xray

apistar-aws-xray's Issues

calculate_sampling_decision has changed input fields.

Hey,

I know this probably won't get a lot of traction as apistar is pretty much abandoned now, but i've noticed an incompatibility with aws-xray-sdk and your code.

error message:

TypeError: calculate_sampling_decision() got an unexpected keyword argument 'service_name'

call in apistar-aws-xray.AWSXrayEventHook

sampling_decision = calculate_sampling_decision(
            trace_header=xray_header,
            recorder=self._recorder,
            service_name=host,
            method=method,
            path=path
        )

in aws_xray_sdk.ext.util

def calculate_sampling_decision(trace_header, recorder, sampling_req):
    """
    Return 1 or the matched rule name if should sample and 0 if should not.
    The sampling decision coming from ``trace_header`` always has
    the highest precedence. If the ``trace_header`` doesn't contain
    sampling decision then it checks if sampling is enabled or not
    in the recorder. If not enbaled it returns 1. Otherwise it uses user
    defined sampling rules to decide.
    """
    if trace_header.sampled is not None and trace_header.sampled != '?':
        return trace_header.sampled
    elif not recorder.sampling:
        return 1
    else:
        decision = recorder.sampler.should_trace(sampling_req)
    return decision if decision else 0