crykn/kryonet

A fork of the KryoNet client/server library for Java.

kryonet's Issues

package does not exist: gradle

I am trying to migrate from the main repository to here in my project.
I have changed my build.gradle to the following and already had jitpack/maven in my repos:

dependencies {
...
    implementation 'com.github.crykn:kryonet:2.22.8'
}

This is the error I get when trying to run:

/Users/asher/code/computer_science/2023/chess/src/main/java/network/KryoRegister.java:5: error: package com.esotericsoftware.kryo does not exist
import com.esotericsoftware.kryo.Kryo;
                                ^
/Users/asher/code/computer_science/2023/chess/src/main/java/network/KryoRegister.java:23: error: cannot find symbol
    private static void registerWithKryo (Kryo kryo) {
                                          ^
  symbol:   class Kryo
  location: class KryoRegister
/Users/asher/code/computer_science/2023/chess/src/main/java/network/KryoRegister.java:49: error: cannot find symbol
        Kryo kryo = client.getKryo();
        ^
  symbol:   class Kryo
  location: class KryoRegister
/Users/asher/code/computer_science/2023/chess/src/main/java/network/KryoRegister.java:54: error: cannot find symbol
        Kryo kryo = server.getKryo();
        ^
  symbol:   class Kryo
  location: class KryoRegister
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
4 errors

My imports in the class KryoRegister look like so:

import com.esotericsoftware.kryo.Kryo;
import com.esotericsoftware.kryonet.Client;
import com.esotericsoftware.kryonet.Server;

Should my imports look different?
Thanks.

Allow usage of SLF4J for logging

I'd love to be able to get KryoNet to use any SLF4J implementation.

Some work has already been done in that regards: https://github.com/hpadmanabhan/kryonet-slf4j/commits/master

MinLog is probably better in terms of performance, but it lacks on the feature side.

This is nothing too alarming or concerning, just a simple convenience thing. If it proves to be too much work to implement, you can probably just ignore it.

Kyro 5.3

Hey, thank you very much for your effort in updating the library! Are you going to update the dependencies to version kyro 5.3 any time soon?
I am thinking about doing it myself and creating a PR if that is alright with you :)

Unable to build project

I'm trying to build the latest release KryoNet 2.22.7 to give this project a try, however I can't get it to build. I am trying to create a jar file to include with my project. This is the output the gradlew.bat gives me when issuing "gradlew build":

E:\Eclipse\workspace\Supergalactix\Supergalactix-core\jars\kryonet-2.22.7>gradlew build
Configuration on demand is an incubating feature.
Download https://repo.maven.apache.org/maven2/com/esotericsoftware/kryo/5.0.0/kryo-5.0.0.pom
Download https://repo.maven.apache.org/maven2/com/esotericsoftware/reflectasm/1.11.9/reflectasm-1.11.9.pom
Download https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/7/oss-parent-7.pom
Download https://repo.maven.apache.org/maven2/com/esotericsoftware/kryo-parent/5.0.0/kryo-parent-5.0.0.pom
Download https://jitpack.io/com/github/esotericsoftware/jsonbeans/0.9/jsonbeans-0.9.pom
Download https://repo.maven.apache.org/maven2/org/objenesis/objenesis/3.0.1/objenesis-3.0.1.pom
Download https://repo.maven.apache.org/maven2/com/esotericsoftware/minlog/1.3.1/minlog-1.3.1.pom
Download https://repo.maven.apache.org/maven2/org/objenesis/objenesis-parent/3.0.1/objenesis-parent-3.0.1.pom
Download https://repo.maven.apache.org/maven2/org/objenesis/objenesis/3.0.1/objenesis-3.0.1.jar
Download https://repo.maven.apache.org/maven2/com/esotericsoftware/minlog/1.3.1/minlog-1.3.1.jar
Download https://repo.maven.apache.org/maven2/com/esotericsoftware/reflectasm/1.11.9/reflectasm-1.11.9.jar
Download https://repo.maven.apache.org/maven2/com/esotericsoftware/kryo/5.0.0/kryo-5.0.0.jar
Download https://jitpack.io/com/github/esotericsoftware/jsonbeans/0.9/jsonbeans-0.9.jar

Task :compileJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Download https://repo.maven.apache.org/maven2/junit/junit/4.12/junit-4.12.pom
Download https://repo.maven.apache.org/maven2/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.pom
Download https://repo.maven.apache.org/maven2/org/hamcrest/hamcrest-parent/1.3/hamcrest-parent-1.3.pom
Download https://repo.maven.apache.org/maven2/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar
Download https://repo.maven.apache.org/maven2/junit/junit/4.12/junit-4.12.jar

Task :compileTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Task :test

com.esotericsoftware.kryonet.JsonTest > testJson FAILED
junit.framework.AssertionFailedError: TCP data is not equal on client. (expected: Data, actual: Data)
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.TestCase.fail(TestCase.java:227)
at com.esotericsoftware.kryonet.JsonTest.testJson(JsonTest.java:115)

23 tests completed, 1 failed

Task :test FAILED

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':test'.

There were failing tests. See the report at: file:///E:/Eclipse/workspace/Supergalactix/Supergalactix-core/jars/kryonet-2.22.7/build/reports/tests/test/index.html

• Try:
  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

• Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.9/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 2m 9s
4 actionable tasks: 4 executed

Thread hanging on Client.dispose()/ Client.close()

I noticed this issue over at EsotericSoftware /
kryonet : EsotericSoftware#142

and remembered that I spent quite a bit of time a few months ago trying to diagnose this, unsuccessfully. I'm curious if that's something that could be addressed on this forked repo in light of some of the info that was posted recently?