Giter Site home page Giter Site logo

Comments (8)

tthvo avatar tthvo commented on May 25, 2024 3

I think the argument to the line below is empty since it is a push event, not a comment event:

username: ${{ github.event.comment.user.login }}

from cryostat.

andrewazores avatar andrewazores commented on May 25, 2024 3

Looks right. @aali309 I'm looking at that build-image step again and I'm still not sure I see why exactly the podman-login action is required. Which subsequent step in that workflow is interacting with ghcr.io? And why would it need to use a commenting user's username as the login while using the secrets.GITHUB_TOKEN as the password?

Can we try just removing the podman-login step and see if anything actually breaks?

from cryostat.

aali309 avatar aali309 commented on May 25, 2024 1

yes when I remove the podman-login

image

workflow LINK: https://github.com/aali309/cryostat/actions/runs/6700548654/job/18206670997

on merge:
image

push-ci workflow LINK: https://github.com/aali309/cryostat/actions/runs/6700624381

from cryostat.

andrewazores avatar andrewazores commented on May 25, 2024

image

Run redhat-actions/podman-login@v1
Error: Error: Input required and not supplied: username

from cryostat.

aali309 avatar aali309 commented on May 25, 2024

image

Run redhat-actions/podman-login@v1
Error: Error: Input required and not supplied: username

I have no clue why it is saying username not supplied when it is supplied on ci-build-image.yml file

from cryostat.

andrewazores avatar andrewazores commented on May 25, 2024

Okay, so removing the podman-login looks OK then. Now it's failing on downloading from the GH Packages Maven repository, so there needs to be some setup with maven-settings ie. ~/.m2/settings.xml.

from cryostat.

aali309 avatar aali309 commented on May 25, 2024

with podman login

/build_test LINK: https://github.com/aali309/cryostat/actions/runs/6700846180

image

retest LINK: https://github.com/aali309/cryostat/actions/runs/6700928824

image

Push to quay fails is expected to fail I assume because of the access restrictions (i.e username+password).
push-ci workflow LINK: https://github.com/aali309/cryostat/actions/runs/6700718429
image

from cryostat.

aali309 avatar aali309 commented on May 25, 2024

Okay, so removing the podman-login looks OK then. Now it's failing on downloading from the GH Packages Maven repository, so there needs to be some setup with maven-settings ie. ~/.m2/settings.xml.

I will try this option tomorrow morning

from cryostat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.