cs-cordero/pylint-enums

A pylint plugin for Enum value annotations and str methods

pylint-enums's Issues

How about to use ClassDef.ancestors method in is_subclass_of_enum?

Hi,

I am using this awesome plugin to lint my python code. I recently found that it can not detect the case when a class is inhereted from Enum indirectly. For example. when I write

from enum import Enum
class A(Enum):
    pass
class B(A):
    a = 1
    b = 2

the linter will post an error message.

The ClassDef class has a ancestors method which can be used to find all the direct and indirect base class of the ClassDef instance. How about to use this method in is_subclass_of_enum function to solve above problem? I think the code may be something like:

def is_subclass_of_enum(node):
    """ Returns whether a base class on the node has the name 'Enum' """
    for base_class in node.ancestors():
        base_class_name = base_class.name
        if base_class_name == 'Enum':
            return True
    return False