cs2103-ay1819s1-t13-4/main

CAPTracker

main's Issues

Edit module command

Edit module command

Write more test for CAP calculation

To ensure all equivalence partition is covered

Implement Adjust command in Logic

Create Logic entry point for Adjust command

Add Delete module command

Add Delete module command

Feedback on week 8 project progress

Subject: feedback on week 8 project progress

See v1.1 progress guide for more details of the activities mentioned below.
Mid-milestone progress reports are FYI only. They are not graded.

Team progress

Leftovers from v1.1

• Auto-publishing set up for the team repo and the website is available at link (:heavy_check_mark: well done!)

• README page:
  • Some parts not related to your product are removed (:heavy_check_mark: well done!)
  • se-edu/addressbook-level[3/4] acknowledged (:exclamation: try to do by next milestone)
  • Ui.png has been updated (:heavy_check_mark: well done!)

Recommended progress for the upcoming milestone

• Issue labels set up e.g., type.*, priority.* (:heavy_check_mark: well done!)
• Milestones created: v1.2 v1.3 v1.4 [Please ensure milestones are setup until 'v1.4'] (:heavy_check_mark: well done!)
• Issues marked as type.Story e.g., (:exclamation: try to do by next milestone)
• Some issues prioritized using priority.* labels e.g., link (:heavy_check_mark: well done!)

• Milestone v1.2 planned
  • A suitable deadline set (:exclamation: try to do by next milestone)
  • Issues allocated to v1.2 e.g., link (:heavy_check_mark: well done!)
  • Issues allocated to v1.3 e.g., (:exclamation: try to do by next milestone)

• Build passing (:exclamation: try to do by next milestone)

Individual progress of @alexkmj

Recommended progress for the upcoming milestone

• Merged updates to java/fxml files (:heavy_check_mark: well done!)
• Has issues/PRs assigned for the next milestone (:exclamation: try to do by next milestone)

Individual progress of @jeremiah-ang

Recommended progress for the upcoming milestone

• Merged updates to java/fxml files (:heavy_check_mark: well done!)
• Has issues/PRs assigned for the next milestone (:heavy_check_mark: well done!)

Individual progress of @jeremyyew

Recommended progress for the upcoming milestone

• Merged updates to java/fxml files (:exclamation: try to do by next milestone)
• Has issues/PRs assigned for the next milestone (:exclamation: try to do by next milestone)

Individual progress of @josephambe

Recommended progress for the upcoming milestone

• Merged updates to java/fxml files (:exclamation: try to do by next milestone)
• Has issues/PRs assigned for the next milestone (:exclamation: try to do by next milestone)

Individual progress of @BugEyedBug

Leftovers from v1.1

• Used forking workflow:
  • Forked team repo (:heavy_check_mark: well done!)
  • Created PRs link (:heavy_check_mark: well done!)
  • Gave review comments to other PRs (:exclamation: try to do by next milestone)

Recommended progress for the upcoming milestone

• Merged updates to java/fxml files (:exclamation: try to do by next milestone)
• Has issues/PRs assigned for the next milestone (:exclamation: try to do by next milestone)

Tutor: @parvathy-sudhir-pillai

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2018-10-11 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

Implement Map DS in UniqueModuleList for O(1) look up

Improve look up efficiency of UniqueModuleList

Allow user to add module into transcript.

Allow user to add module into transcript.

Add SD for Target Grade and Current CAP calculation

Needs some Sequence Diagrams

Reposense not detecting commits

Reposense not detecting commits. Custom _reposense/config.json has to be created to reflect the commits.

Routing of commands starting with "c_" to TranscriptParser

Routing of commands starting with c_ to TranscriptParser

Implement interface in Model for Logic to UI to get cap goal value

-1 if not set, otherwise it'll be 0 or a positive value

Generate collate folder

Generate collate folder

New GUI layout

Without data.

Update Developer Guide - Design - UI Component

Need to change things like "PersonCard" to "ModuleCard" and etc...

Can one of you claim this task?

@josephambe
@jeremyyew

Update Error Message in Results Display Panel

Correct the current message displayed when user enters invalid command. Match it to Modules/CAPGOAL APP rather than People/ADDRESSBOOK APP. Show proper example that will work for CAPGOAL purposes.

Missing annotations by alexkmj

Remember to annotate.

Module code and Grade value should be in uppercase for consistency and to prevent duplications

Module code and Grade value should be in uppercase for consistency and to prevent duplications

Implement command for user to obtain target grades

For Must have user story 7

• As a user, I can calculate the average mark I need across the modules I’ve entered so I can see what mark I need for each module to achieve my CAP goal.

Add method to check for multiple instances of modules with same module code

Add method to check for multiple instances of modules with same module code

Implement new command in logic to trigger target grades calculation

targetGrades should trigger command

Fix User Guide error on goal command

Goal command is to set the goal not to compute CAP

Move state of grade to Grade have 3 different states

Move state to Grade

• Complete
• Target
• Adjust

UniqueModuleList setModule should use isSameMode instead of equals

Feedback on week 9 project progress

Subject: feedback on week 9 project progress

See v1.2 progress guide for more details of the activities mentioned below.

Team progress

Leftovers from v1.1

• Auto-publishing set up for the team repo and the website is available at link (:heavy_check_mark: well done!)

• README page:
  • Some parts not related to your product are removed (:heavy_check_mark: well done!)
  • se-edu/addressbook-level[3/4] acknowledged (:exclamation: try to do by next milestone)
  • Ui.png has been updated (:heavy_check_mark: well done!)

Recommended progress for v1.2

• Issue labels set up e.g., type.*, priority.* (:heavy_check_mark: well done!)
• Milestones created: v1.4 v1.2 v1.3 [Please ensure milestones are setup until 'v1.4'] (:heavy_check_mark: well done!)
• Some issues marked as type.Story e.g., link (:heavy_check_mark: well done!)
• Some issues prioritized using priority.* labels e.g., link (:heavy_check_mark: well done!)

• Milestone v1.2 managed systematically
  • A suitable deadline set (:heavy_check_mark: well done!)
  • Issues allocated to v1.2 e.g., link (:heavy_check_mark: well done!)
  • All issues/PRs in it are closed/merged. (:heavy_check_mark: well done!)
  • Milestone closed (:exclamation: try to do by next milestone)
  • Code tagged as v1.2 (:heavy_check_mark: well done!)

• Build passing (:heavy_check_mark: well done!)
• Some issues assigned to milestone v1.3 e.g., link (:heavy_check_mark: well done!)

Not graded:

• Updated User Guide for v1.2 (:+1: Kudos!)

Individual progress of @alexkmj

Recommended progress for v1.2

• Merged updates to java/fxml files (:heavy_check_mark: well done!)
• Merged updates to the Developer Guide (:heavy_check_mark: well done!)
• Has issues/PRs assigned for v1.2 milestone (:heavy_check_mark: well done!)

Individual progress of @jeremiah-ang

Recommended progress for v1.2

• Merged updates to java/fxml files (:heavy_check_mark: well done!)
• Merged updates to the Developer Guide (:heavy_check_mark: well done!)
• Has issues/PRs assigned for v1.2 milestone (:heavy_check_mark: well done!)

Individual progress of @jeremyyew

Recommended progress for v1.2

• Merged updates to java/fxml files (:heavy_check_mark: well done!)
• Merged updates to the Developer Guide (:heavy_check_mark: well done!)
• Has issues/PRs assigned for v1.2 milestone (:heavy_check_mark: well done!)

Individual progress of @josephambe

Leftovers from v1.1

• Used forking workflow:
  • Forked team repo (:heavy_check_mark: well done!)
  • Created PRs link (:heavy_check_mark: well done!)
  • Gave review comments to other PRs (:heavy_check_mark: well done!)

• Merged updates to documents (:exclamation: try to do by next milestone)
• josephambe.png uploaded and linked from AboutUs page in png format (change image to png if presently in different format) (:heavy_check_mark: well done!)

Recommended progress for v1.2

• Merged updates to java/fxml files (:exclamation: try to do by next milestone)
• Merged updates to the Developer Guide (:exclamation: try to do by next milestone)
• Has issues/PRs assigned for v1.2 milestone (:exclamation: try to do by next milestone)

Individual progress of @BugEyedBug

Leftovers from v1.1

• Used forking workflow:
  • Forked team repo (:heavy_check_mark: well done!)
  • Created PRs link (:heavy_check_mark: well done!)
  • Gave review comments to other PRs (:exclamation: try to do by next milestone)

• Merged updates to documents (:exclamation: try to do by next milestone)
• bugeyedbug.png uploaded and linked from AboutUs page in png format (change image to png if presently in different format) (:heavy_check_mark: well done!)

Recommended progress for v1.2

• Merged updates to java/fxml files (:exclamation: try to do by next milestone)
• Merged updates to the Developer Guide (:exclamation: try to do by next milestone)
• Has issues/PRs assigned for v1.2 milestone (:exclamation: try to do by next milestone)

Tutor: @parvathy-sudhir-pillai

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2018-10-18 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

Display module and CAP data in GUI.

Update documentation to resolve issues pointed out by TA

Update documentation to resolve issues pointed out by TA in PR#12

README.adoc

• Change "ideal" CAP to "target" CAP
• AB-4 should be part of acknowledgements

docs/UserGuide.adoc

• Clarify the format for edit

docs/DeveloperGuide.adoc

• Should be "An" NUS student not "A" NUS student
• Duplicate must have story (5 and 6)
• Seems too vague. How do you track progress with only grades? What do you track progress of?

src/main/java/seedu/address/logic/commands/CapCommand.java

• "Shows" (descriptive style) instead of "Show"
• Avoid unnecessary line breaks between import statements
• "Parses" instead of "Parse"

docs/AboutUs.adoc

• Suggested Jeremiah to change to a bigger photo

Update Developer Guide - Design - Storage

Need to update whatever XML to JSON

Feedback on week 7 project progress

Subject: feedback on week 7 project progress

See v1.1 progress guide for more details of the activities mentioned below.

Team progress

• Team org and repo set up correctly (:heavy_check_mark: well done!)
• PR created from team repo to AB-4 (:heavy_check_mark: well done!)
• Auto-publishing set up for the team repo (:heavy_check_mark: well done!)

• README page:
  • Ui.png has been updated (:heavy_check_mark: well done!)

• User Guide: some content has been updated (:heavy_check_mark: well done!)
• Developer Guide: some content has been updated (:heavy_check_mark: well done!)
• Team repo git tagged as v1.1 (:heavy_check_mark: well done!)

Individual progress of @alexkmj

• Used forking workflow:
  • Created PRs (:heavy_check_mark: well done!)
  • Reviewed PRs (:heavy_check_mark: well done!)

• Merged updates to documents (:heavy_check_mark: well done!)
• alexkmj.png uploaded and linked from AboutUs page, merged (:heavy_check_mark: well done!)

Individual progress of @jeremiah-ang

• Used forking workflow:
  • Created PRs (:heavy_check_mark: well done!)
  • Reviewed PRs (:heavy_check_mark: well done!)

• Merged updates to documents (:heavy_check_mark: well done!)
• jeremiah-ang.png uploaded and linked from AboutUs page, merged (:heavy_check_mark: well done!)

Individual progress of @jeremyyew

• Used forking workflow:
  • Created PRs (:heavy_check_mark: well done!)
  • Reviewed PRs (:heavy_check_mark: well done!)

• Merged updates to documents (:heavy_check_mark: well done!)
• jeremyyew.png uploaded and linked from AboutUs page, merged (:heavy_check_mark: well done!)

Individual progress of @josephambe

• Used forking workflow:
  • Created PRs (:exclamation: try to do by next milestone)
  • Reviewed PRs (:exclamation: try to do by next milestone)

• Merged updates to documents (:exclamation: try to do by next milestone)
• josephambe.png uploaded and linked from AboutUs page, merged (:heavy_check_mark: well done!)

Individual progress of @BugEyedBug

• Used forking workflow:
  • Created PRs (:exclamation: try to do by next milestone)
  • Reviewed PRs (:exclamation: try to do by next milestone)

• Merged updates to documents (:exclamation: try to do by next milestone)
• bugeyedbug.png uploaded and linked from AboutUs page, merged (:heavy_check_mark: well done!)

Tutor: @parvathy-sudhir-pillai

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2018-10-04 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

Update Developer Guide - Design - Logic

Need to change anything AddressBook to Transcript and add any new parts to it.

Feedback on week 6 project progress

Subject: feedback on week 6 project progress

See mid-v1.1 progress guide for more details of the activities mentioned below.

Team progress

Progress noted (well done! 👍):

• Team org and repo set up with the correct names.
• PR created from team repo to AB-4 accordingly.

Suggestions (to do soon):

None

Individual progress of @alexkmj:

Progress noted (well done! 👍):

• Team repo forked to your GitHub account.
• PRs created to update documents.

Suggestions (to do soon):

• Create PRs to do a local change to the Java code.

Individual progress of @jeremiah-ang:

Progress noted (well done! 👍):

• Team repo forked to your GitHub account.
• PRs created to update documents.

Suggestions (to do soon):

• Create PRs to do a local change to the Java code.

Individual progress of @jeremyyew:

Progress noted (well done! 👍):

• Team repo forked to your GitHub account.

Suggestions (to do soon):

• Create PRs for your share of updating documents.
• Create PRs to do a local change to the Java code.

Individual progress of @josephambe:

Progress noted (well done! 👍):

• Team repo forked to your GitHub account.

Suggestions (to do soon):

• Create PRs for your share of updating documents.
• Create PRs to do a local change to the Java code.

Individual progress of @BugEyedBug:

Progress noted (well done! 👍):

• Team repo forked to your GitHub account.

Suggestions (to do soon):

• Create PRs for your share of updating documents.
• Create PRs to do a local change to the Java code.

Tutor: @parvathy-sudhir-pillai

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 19/9/2018 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

Provide Interface for UI from Logic

Interface specification to be filled by @jeremyyew and @josephambe

Update comparison implementation of module

Module is totally equal if all properties are equal otherwise it is considered same module if the code + year + sem is the same

[W6.10] User Guide has to updated

Add unit testing for undo redo command

Add unit testing for undo redo command

Get drop down menu's working again

Currently the drop down menu's in UI don't register the mouse hovering over them or work when you click them. Need to fix.

Acknowledge SE-EDU3/4 in README.adoc

Acknowledge SE-EDU3/4 in README.adoc to comply with the feedbackbot

Improve Use Case write up

Follows format of AB4 i.e. using MSS and Extensions

Update Developer Guide - Design - Model

Need to update anything AddressBook/Person to Transcript/Module/CapGoal/Cap etc...

Wrong profile picture link in about page

alexkmj.jpg should be alexkmj.png

Fix bug for ParserUtil.tokenizer

Tokenizer does not split properly with multiple white-spaces or non space white-spaces. This PR address this issue and adds test cases for it.

Constants for code, year, credit, and grade in TypicalModule to prevent defining them in other places.

Currently code, year, credit, and grade has been defined in other tests. Any change in code, year, credit or grade class may break those test cases and we have to edit many of the test cases.

Annotate code for alexkmj

Annotate code for alexkmj

Write more test for Adjusting target grades

To ensure all equivalence partition is covered

Add methods to TestApp to support system tests

Add methods for TestApp to create defensive copies of Transcript for system testing purposes.
Add helper methods in ModelHelper.

Extract CapGoal as a Class

Extract as another class CapGoal (Similarly to Module parameter)

Checks for validity and also has a NIL value

Feedback on week 10 project progress

Subject: feedback on week 10 project progress

See mid-v1.3 progress guide for more details of the activities mentioned below.

Team progress

Recommended progress for v1.3

• Milestone v1.3 managed systematically
  • A suitable deadline set (:exclamation: try to do by next milestone)
  • Issues allocated to it e.g., link (:heavy_check_mark: well done!)

• A new jar file has been released on GitHub (:exclamation: try to do by next milestone)

Individual progress of @alexkmj

Recommended progress for v1.3

• Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @jeremiah-ang

Recommended progress for v1.3

• Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @jeremyyew

Recommended progress for v1.3

• Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @josephambe

Leftovers from v1.2

• Merged updates to the Developer Guide (:exclamation: try to do by next milestone)

Recommended progress for v1.3

• Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Individual progress of @BugEyedBug

Leftovers from v1.2

• Merged updates to the Developer Guide (:exclamation: try to do by next milestone)

Recommended progress for v1.3

• Has issues/PRs assigned for the milestone (:heavy_check_mark: well done!)

Tutor: @parvathy-sudhir-pillai

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2018-10-25 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

Missing Annotation by jeremiah-ang

annotation missing.

Write more test for Target Grades calculation

To ensure all equivalence partition is covered

Add code annotations for @jeremyyew

Provide API interface for UI from ReadOnlyTranscript

Provide API for UI from ReadOnlyTranscript

• getCurrentCap()
• getCapGoal()
• filtersModuleList()