[DX] Github action for deployment

[Dun-sin]

[DX] Github action for deployment

[iShibi]

If you want to look at a similar Github action here it is

It's not about automating. The said GitHub action will do the same thing that vercel is doing currently. It's about securing secrets stored in the environment variable. Someone can open a PR to get those secrets and we will be too late to do anything as the CI will build it automatically. On per PR basis we can first check that the PR is not doing anything with the secrets and then authorize the build.

[iShibi]

If you have set secrets in Environment Variables on vercel then I'll say keep it enabled and allow it to run on each PR after checking its changes. This would be time consuming but a safer option.

[Dun-sin]

@Dun-sin hmm when something is merged into main, it's already deployed into the main Vercel instance. So I'm not sure if that's necessary actually

I know, personally I thought the issue to the bot giving those warnings is because it was getting from a branch.

So I created a Github action to make vercel not deploy in any branch unless it's the main one.

It fixed the issue without me having to turn off the protection in vercel itself

[Dun-sin]

Ah I see.

Still from my perspective, it is really convenient to be able to review the changes on a Vercel instance. As you mentioned, it's good for reviewing things visually

Yes, it doesn't take away the preview part of things. Just holds up the actual deployment until merged into main

[iShibi]

This is just vercel trying to be secure by default and it can be fixed by turning off git-fork-protection in the project settings:

@ykdojo

[ykdojo]

Hmm interesting. Do you think it's safe to turn it off @iShibi?

[Dun-sin]

If you want to look at a similar Github action here it is

[ykdojo]

@Dun-sin hmm when something is merged into main, it's already deployed into the main Vercel instance. So I'm not sure if that's necessary actually

[ykdojo]

Ah I see.

Still from my perspective, it is really convenient to be able to review the changes on a Vercel instance. As you mentioned, it's good for reviewing things visually