cucumber/tag-expressions

Cucumber tag expression parser

tag-expressions's Issues

Document escaping syntax

When we merged cucumber/common#1782 (before the code was moved to this repo) we forgot to verify that the new escaping rules were documented (in the README.md). We should document the rules.

Not.to_string() conversion has unneeded double-parenthesis if the inner expression is a binary operator

👓 What did you see?

If a tag-expression contains a not operator that encapsulate a binary operator (and, or),
the string conversion currently leads to double-parenthesis (unnecessary tautology).
This makes the textual string less readable and understandable.

EXAMPLE:

# SOURCE: testdata/parsing.yml
# HINT: This data or similar examples are currently missing

- expression: 'not (a and b)'
  formatted.currently: 'not ( ( a and b ) )'
  formatted.should_be: 'not ( a and b )'

REASONS:

• The binary operators put already parenthesis around their boolean expression during string conversion
• If the not operator does the same (as it currently is implemented), we get two groups of parenthensis

AFFECTED:

• ALL tag-expression implementations

✅ What did you expect to see?

Only one parenthesis grouping, like the formatted.should_be case shown in the example above.

📦 Which tool/library version are you using?

I added additional case to the testdata/parsing.yml in my local workspace and run Java, Javascript and Go implementations.
Each failed the new additional tests.
The non-tested implementations (Ruby and Perl) are also be affected (as expected), by inspection of their implementation.

🔬 How could we reproduce it?

Add the following test-data items to testdata/parsing.yml:

# SOURCE: testdata/parsing.yml

# BAD_EXAMPLES (how the string output currently is):

- expression: 'not (a and b)'
  formatted: 'not ( ( a and b ) )'
- expression: 'not (a or b)'
  formatted: 'not ( ( a or b ) )'
- expression: 'not (a and b) and c or not (d or f)'
  formatted: '( ( not ( ( a and b ) ) and c ) or not ( ( d or f ) ) )'

# GOOD_EXAMPLES (how the output should be):

- expression: 'not (a and b)'
  formatted: 'not ( a and b )'
- expression: 'not (a or b)'
  formatted: 'not ( a or b )'
- expression: 'not (a and b) and c or not (d or f)'
  formatted: '( ( not ( a and b ) and c ) or not ( d or f ) )'

Steps to reproduce the behavior:

0. Update the local workspace to the current HEAD of the GitHub:/cucumber/tag-expression repository.
1. Patch the testdata file
2. Run the tests for each implementation

📚 Any additional context?

Nope.

Perl: Automate releases

We've adopted a release process based on GitHub Actions - documented in RELEASING.md

In order to automate Perl releases, we need a new .github/workflows/release-cpan.yml

Perl: Make tests pass against shared test data

In #9 we introduced shared test data. The Perl implementation should be updated to:

• Run all tests in testdata/*.yml
• Update the implementations to make those tests pass

Dependency Dashboard

This issue provides visibility into Renovate updates and their statuses. Learn more

This repository currently has no open or pending branches.

---

• Check this box to trigger a request for Renovate to run again on this repository

Migrate new commits from the monorepo

Refs. cucumber/common#1778
Refs. cucumber/common#1782

There are at least two PRs on the monorepo for the tag-expressions module.
We will have to migrate them at some point.

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: ^*.gemspec
Error type: Invalid regular expression: ^*.gemspec

Python: Make tests pass against shared test data

In #9 we introduced shared test data. The Python implementation should be updated to:

• Run all tests in testdata/*.yml
• Update the implementations to make those tests pass

Python: Automate releases

We've adopted a release process based on GitHub Actions - documented in RELEASING.md

In order to automate Python releases, we need a new .github/workflows/release-pypi.yml