cuducos/bot-followers

🍊 Find out how many bots follow any given Twitter acount

bot-followers's Issues

Enhance Django Admin integration

The way I integrated the app in Django Admin is too hacky and can be improved in several ways:

• Use Django Admin action to re-start/pause jobs (instead of hardcoded buttons pointing to non-admin URLs)
• Customize the Django Admin add job (so we can remove the hardcoded form on the bottom of the screen)

We can minimize Django Admin template customization this way, and considerably enhance maintainability.

web.core.external could be extracted to web.[lib|external].botometer

The whole external package looks libe a botometer package library that other people could use.

Also I would add the proper import interface via botometer/__init__.py.

This would make clear how core connects with it.

Adapt error message to z-score settings

In the admin template, there's a fixed message regarding the error:

bot-followers/web/templates/admin/change_list.html

Line 83 in 67b1805

<small>* Errors for 95% confidence.</small>

This confidence assumes a z-score of 1.96. But this value can be easily changed:

bot-followers/web/settings.py

Line 147 in 67b1805

Z_SCORE = config("Z_SCORE", default="1.96", cast=float) # default 0.95 confidence

Thus we need to adapt the template message to other z-scores.

I don't think we need a complicated math to beging with. Just a dictionary {1.96: '95%'} would be enough and we just don't show the error/confidence message if the z-score in use is not on the dictionary.

Wouldn't it be better as a class attribute?

bot-followers/web/core/forms.py

Line 7 in 5db04fb

TWITTER_SCREEN_NAME = r"^[a-zA-Z0-9_]{1,15}$"

Update ImportError message in the manage.py file

Hello, I would like to update the ImportError message in the manage.py file to make it more user-friendly.

Could you please assign this to me?

Error ao subir o servidor localmente: No directory at: /web/staticfiles/

Quando tento subir o servidor usando o comando docker-compose run --rm django um alerta aparece indicando a ausencia da pasta /web/staticfiles conforme abaixo.

System check identified no issues (0 silenced).
December 09, 2019 - 20:52:50
Django version 3.0, using settings 'web.settings'
Starting development server at http://0.0.0.0:8000/
Quit the server with CONTROL-C.
/usr/local/lib/python3.8/site-packages/whitenoise/base.py:116: UserWarning: No directory at: /web/staticfiles/
  warnings.warn(u"No directory at: {}".format(root))

Quando tento acessar o endereço http://localhost:8000 a resposta é como se o servidor não estivesse rodando (Unable to connect)

Se eu uso o comando docker-compose up django o mesmo alerta é exibido, mas quando tento acessar a página recebo como resposta um 404.

rodei as migrations e segui o readme. Não sei se o alerta é responsavel pelo erro, mas esse é o passo a passo que testei aqui.

Replace None with empty string

In the report, inside Django Admin, when there's no data to show, None in being converted do 'None':

I think an empty string ('') would give us a better UI.