cuhu / supportkit-android Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 340 KB

Support kit for Android

Java 100.00%

supportkit-android's Introduction

supportkit-android's People

Contributors

Watchers

supportkit-android's Issues

Localization Issues

All messages and titles are defined in SupportKitConstants as static final members.
This makes it impossible to localize them. It's much better to use the string.xml file.

Naming

Using the prefix -kit is common in iOS development as Apple calls a lot of their framework in this way. In Android this is not true and what it happens, it is just a port from iOS.

Prefer a simple name such as Support, DreamrSupport

SupportKitBuilder - baseEmailSet

Calling SupportKitBuilder.setEmailTo with null will cause the flag baseEmailSet to be set to true.

create a getter boolean isEmailSet() checking that email != null

References to endpoint

The support kit does not an endpoint to call to send feedback. Remove all the code associated with it.

SupportKitBuilder - setEmailTo

Not following the standard naming. setEmail would be better

SupportKit prefix

All classes are prefixed by SupportKit, but this is not necessary as java is namespaced by the package name. It would be much better to simply have Issue, Dialog, etc

Recommend Projects