cursedflames/modifiers

Minecraft mod that adds Terraria-style modifiers to equipment.

modifiers's Issues

[1.20.1 Forge] Damage buff from Modifiers doesn't work

The weapon that has a "Deadly" modifier doesn't add the Attack Damage buff it is supposed to. Other modifiers like "Speed" do work as intended. also, "Attack Speed" seems not to work as well but I don't have proof for it.

This is a comparison screenshot for the Attack Damage bug

as you can see, the attribute didn't work because the Attack Damage of the sword is still 8 while it is supposed to say 9.2 according to the calculator

Modifiers vs Tiered. What are the differences.

https://www.curseforge.com/minecraft/mc-mods/tiered
I just don't know which one to use.
In Modifiers there seems to be a delay between taking a tool and applying a modifier on it.
Is there a list off all your modifiers?

1.19.2？

Hi, just see that you created 1.20 branch yesterday.
Do you consider backporting it to 1.19.2? Currently popular modpacks mc version.
It shouldn't very hard in my opinion, or if you don't want to spend energy on this, I can backport it and send a PR for you.

1.16version cannot be build

Lack of dependencies

4:22:29

12:20:09

• What went wrong:
  Plugin [id: 'architectury-plugin', version:'2.0.65'] was not found in any of the following sources:
  -Gradle Core Plugins (not a core plugin, please see https://docs.gradle.org/6.8/userguide/standard_plugins.htmlforavailablecoreplugins)
  -Plogin Repositories (could not resolve plugin artifact'architectury-plugin:architectury-plugin. gradle. plugin:2.0.65°) Searched in the following repositorie
  s:
  BintrayJCenter
  maven( https://maven.fabricmc.net/)
  maven2( https://d1.bintray.com/shedaniel/cloth)
  maven3( https://files.minecraftforge.net/maven/)
  Gradle Central Plugin Repository
• Try:
  Run with —stacktrace option to get the stack trace. Run with —info or —debug option to get more log output. Run with —sc an to get full insights.

[Suggestions] More Weapons / Mod Support and use of config.

Hi, im liking the mod and the concept (Terraria is a good game), enough to the point to create a kubejs script to add more terraria modifers to the modifier pools.

The following are suggestions that, from my use, I would like to see:

• More Weapon Support
  From my reading in your source code, you are already planning to support tridents and bows possibly in the future. I would enjoy if you were to allow support for perhaps other weapon types (iron spell books staffs for magical etc). This would likely require other modifier pools to be created - perhaps you could lean further into the terraria style and differentiate the pools based on their usecase / damage type (https://terraria.fandom.com/wiki/Modifiers) such as a pool for melee, ranged, magic, armor / accessories, and make use of a config to allow players to add items / tags to configure the items these pools apply to, rather than them requesting compats.

• A General Config
  Currently, to my knowledge, the mod does not have a config to fine tune certain aspects of the mod to a player's liking (eg. rarity of reforge templates, which base mod modifers are active, etc), While these are not exactly useful for me as i can modify them via a script in Kubejs, this may be a good choice for a player who just wants to plug and play with the mod.
  Also, as said previously, the config could be used to define a set of item ids that pools will apply to, regardless of context, allowing modpacks to be more creative with the modifiers. This is currently an issue for me as the modifiers only apply to items of either SwordItem or ArmorItem, maybe the use of a tag or config array would be better for a more general application.

These are just my general thoughts as im liking the mod as it is currently. Also, making some methods in Modifiers.java public,

private static Modifier.ModifierBuilder curio(String name) {};
private static Modifier.ModifierBuilder tool(String name) {};
private static void addCurio(Modifier modifier) {};
private static void addTool(Modifier modifier) {};
private static Modifier.AttributeModifierSupplier mod(double amount, Operation op) {};

would make my life scripting nicer (im currently just recreating them), and maybe including a remove method in the modifier_pool class would be a better option for me :P

Balancing

I really like the idea of this mod! I think some balancing is needed though, because all of the modifiers currently added are beneficial and there's no need to resmith anything. Terraria balanced this by adding some negative modifiers, which I think this mod should do as well.

Additionally, a cost to use the smithing table might be necessary.

1.20.1 Mixin Crash

https://gist.github.com/Xaikii/299d00c6c3ca21dba07e9a4741c02d91

Forge: 47.3.0
MC: 1.20.1
Modifiers: 0.1.3

Crash With ssn and curios

When equipping a simple storage netwrok remote from the mod simple storage network
The game will crash

crash report
crash-2022-04-09_00.29.14-client.txt

logs
latest.log

Mods involved

Forge Version 36.2.29
curios-forge-1.16.5-4.0.8.1
jei-1.16.5-7.7.1.152
modifiers-0.1.2-forge
SimpleStorageNetwork-1.16.5-1.5.2

https://streamable.com/di0pkl

[1.20.1] Tick loop Crash when opening chest / fighting entity

crash-2023-07-11_14.12.41-server.txt
crash-2023-07-11_14.53.04-server.txt

Cannot load game with Modifiers installed

Attempting to launch the game results in a crash with error:

java.lang.NullPointerException: Initializing game
at cursedflames.modifiers.common.modifier.ModifierHandler.getModifier(ModifierHandler.java:56) ~[modifiers:?] {re:mixin,re:classloading}
at net.minecraft.item.Item.handler$zfg000$onGetDisplayName(Item.java:1020) ~[?:?] {re:computing_frames,pl:accesstransformer:B,xf:fml:forge:crossbows.8,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:forge:crossbows.8,pl:mixin:APP:charm.mixins.json:accessor.ItemAccessor,pl:mixin:APP:modifiers.mixins.json:MixinItem,pl:mixin:APP:foragecraft.main.mixins.json:ItemMixin,pl:mixin:A}
at net.minecraft.item.Item.func_200295_i(Item.java:227) ~[?:?] {re:computing_frames,pl:accesstransformer:B,xf:fml:forge:crossbows.8,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:forge:crossbows.8,pl:mixin:APP:charm.mixins.json:accessor.ItemAccessor,pl:mixin:APP:modifiers.mixins.json:MixinItem,pl:mixin:APP:foragecraft.main.mixins.json:ItemMixin,pl:mixin:A}
at com.someguyssoftware.treasure2.item.LockItem.lambda$appendHoverText$0(LockItem.java:102) ~[treasure2:mc1.16.5-f36.1.0-v1.0.1] {re:classloading}
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) ~[?:1.8.0_292] {}
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384) ~[?:1.8.0_292] {}
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) ~[?:1.8.0_292] {}
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) ~[?:1.8.0_292] {}
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) ~[?:1.8.0_292] {}
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:1.8.0_292] {}
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566) ~[?:1.8.0_292] {}
at com.someguyssoftware.treasure2.item.LockItem.func_77624_a(LockItem.java:103) ~[treasure2:mc1.16.5-f36.1.0-v1.0.1] {re:classloading}
at net.minecraft.item.ItemStack.func_82840_a(ItemStack.java:578) ~[?:?] {re:mixin,re:classloading,xf:fml:forge:filled_map.4,xf:fml:forge:itemstack,pl:mixin:APP:modifiers.mixins.json:client.MixinItemStack,pl:mixin:A}
at net.minecraft.client.Minecraft.func_213251_b(Minecraft.java:642) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftAccessor,pl:mixin:APP:mining_helmet.mixins.json:MinecraftMixin,pl:mixin:APP:justenoughkeys.mixins.json:MinecraftMixin,pl:mixin:APP:assets/mining_dimension/mining_dimension.mixins.json:MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.util.SearchTree.func_194042_b(SourceFile:36) ~[?:?] {re:classloading}
at net.minecraft.client.util.SearchTreeReloadable.func_217872_a(SourceFile:48) ~[?:?] {re:classloading}
at net.minecraft.client.Minecraft.lambda$createSearchTrees$10(Minecraft.java:660) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftAccessor,pl:mixin:APP:mining_helmet.mixins.json:MinecraftMixin,pl:mixin:APP:justenoughkeys.mixins.json:MinecraftMixin,pl:mixin:APP:assets/mining_dimension/mining_dimension.mixins.json:MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_292] {}
at net.minecraft.client.Minecraft.func_193986_ar(Minecraft.java:659) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftAccessor,pl:mixin:APP:mining_helmet.mixins.json:MinecraftMixin,pl:mixin:APP:justenoughkeys.mixins.json:MinecraftMixin,pl:mixin:APP:assets/mining_dimension/mining_dimension.mixins.json:MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.(Minecraft.java:476) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftAccessor,pl:mixin:APP:mining_helmet.mixins.json:MinecraftMixin,pl:mixin:APP:justenoughkeys.mixins.json:MinecraftMixin,pl:mixin:APP:assets/mining_dimension/mining_dimension.mixins.json:MinecraftMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:149) ~[minecraft-1.16.5-client.jar:?] {re:classloading,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {}
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.1.30-launcher.jar:36.1] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {re:classloading}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {re:classloading}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {}
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {}
at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:52) [ForgeWrapper-1.5.1.jar:1.5.1] {}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {}
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {}
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210) [NewLaunch.jar:?] {}
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245) [NewLaunch.jar:?] {}
at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?] {}
at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?] {}

No config for disabling some modifiers.

1.17?

No modifiers showing up

There literally aren't any modifiers.