cuzy-app/clean-theme

clean-theme's Issues

HumHub 1.15.0-beta.1: Error when disabling theme

HumHub: 1.15.0-beta.1
Clean Theme Module: 1.5.0

When I activate the clean-theme module and deactivate it right after, I get the following error.
Probably because module disabling is now done in a background job. So the theme views are still active but the module is not available.
The error disappeary after the background job has finished.

yii\base\ErrorException: Attempt to read property "collapsibleLeftNavigation" on null in /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/modules/clean-theme/themes/clean-base/views/ui/menu/widgets/views/left-navigation.php:25
Stack trace:
#0 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/modules/clean-theme/themes/clean-base/views/ui/menu/widgets/views/left-navigation.php(25): yii\base\ErrorHandler->handleError()
#1 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(347): require('...')
#2 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(257): yii\base\View->renderPhpFile()
#3 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(156): yii\base\View->renderFile()
#4 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Widget.php(249): yii\base\View->render()
#5 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/modules/ui/menu/widgets/Menu.php(91): yii\base\Widget->render()
#6 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/components/Widget.php(63): humhub\modules\ui\menu\widgets\Menu->run()
#7 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/modules/admin/views/layouts/main.php(10): humhub\components\Widget::widget()
#8 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(347): require('...')
#9 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(257): yii\base\View->renderPhpFile()
#10 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(156): yii\base\View->renderFile()
#11 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/components/Controller.php(144): yii\base\View->render()
#12 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Controller.php(408): humhub\components\Controller->renderContent()
#13 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/modules/admin/controllers/ModuleController.php(65): yii\base\Controller->render()
#14 [internal function]: humhub\modules\admin\controllers\ModuleController->actionList()
#15 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array()
#16 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Controller.php(178): yii\base\InlineAction->runWithParams()
#17 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Module.php(552): yii\base\Controller->runAction()
#18 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/web/Application.php(103): yii\base\Module->runAction()
#19 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Application.php(384): yii\web\Application->handleRequest()
#20 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/index.php(25): yii\base\Application->run()
#21 {main} 

Issues with bottom menu

First of all I really like the bottom menu. Thanks for adding it in a free module.

I am testing on Android 13 with an up to date HumHub instance and clean-base.

1. The active icon has dark background when I first open the site or reload it. When I navigate there from another page it is just darker icon color.

First page load:

Navigating to it:

2. The Space chooser does not show at all.
   

Dark Mode: unread notification background

There is an issue reported on felixhahnweilheim/humhub-dark-mode#54

It is only with the clean theme, so I add it here.

It seems this line does not work as expected: https://github.com/cuzy-app/humhub-modules-clean-theme/blob/master/themes/clean-base/less/dark/clean-dark-colors.less#L22

I am not at home today, so I can't look into it but I wanted to let you know @marc-farre

Mobile: top bar issues with added items in the notifications block such as the night mode button

Hi, with HumHub 1.15.0-beta.1 I have following issue on my phone (PWA).

The menu icon from topbar is missplaced and the search text overlaps, see screenshot.
When I swipe to the sidebar (e.g. dashboard), the topbqr shows correct. But when I swipe back it comes again.

Clean Theme v1.5.0
Theme: clean-base

Space title hard to read when banner image in use

When using a background image in the Space header, the Space title becomes unreadable quickly as the font color is set to #76838f - a light grey which has little contrast to mixed-color images.

I can think of a few options

1. Auto-detected background color to adjust font color to a high contrast
2. Create an additional layer in-between the image and the text to blur the image colors
3. Find a high-contrast font color - which might be impossible
4. Add a text-shadow that has a high contrast to the font color

None of the solutions feel clean and/ or easy enough to propose as solution, hence the full listing of ideas.

CSS border attribute inconsistent for user thumbnails

The visual for user thumbnail is formatted inconsistently.

In the Space members view, a user thumbnail defines border: 1px solid #21A1B3;, which results in the following visual

In other places the border attribute is not defined, resulting in

The places I could identify so far

• Space member widget displays border
• Latest activities widget does not displays border
• Profile menu (top right) does not display border
• Stream does not display borders
• People directory does not display borders

Personally speaking the border provides a little bit of visual boundary and makes for smoother visuals. The metaphor of a picture frame comes to mind. I would prefer a darker color over the
greenish one used in the Space member widget.

Not sure though if this matches with the intention of clean for this theme. Please disregard my personal preferences if not.

On mobile, top menu dropdown notification panels are not centered on the screen and the logo is hidden

Hi,
as you can see on the screenshots, iPhone 14 produces some representation error regarding the margins. This is when you chose the messages or the notifications button at the top.
Another thing I miss is the logo of the instance which was, were the search icon now is. I miss the comfort of clicking the logo to get back to the dashboard. Thanks a lot for your work!

Add safe area for iPhone X and above to the bottom menu

The issue:

Solutions tried:
5db0fea#diff-c0399b3002e6de34886f1b5fafffce89cd991e9ef5d5f2f7147d0eaa99d4c0b4R76
And
5e1ad7a

But it doesn't fix it.
So I had to add 20px of padding bottom for all devices:
976d349#diff-c0399b3002e6de34886f1b5fafffce89cd991e9ef5d5f2f7147d0eaa99d4c0b4R76

As I don't have access to an iPhone X or later, I cannot test more and fix the issue, because online iPhone simulator doesn't simulate the bottom page correctly.

Position of notifications (+ mail) dropdown on mobile

The notifications dropdown overlaps the screen in the mobile view, see screenshot:

The same is with the message dropdown of the mail module:

Apart from that great module! Thanks for making it free.

1.7.x display issues on mobile

Marc,

1.6.0 worked great.

1.7.0 has some nice new features, but here is feedback as to why we reverted back to 1.6.0 for now:

The split menu is bad for us for these reasons:

1. The names disappear for the menu items, and the users don't know what does what.
2. The site name ends up wrapping to two lines at the top, causing it to float above content below the menu.

If we move to 1.7.0 we must have a way to disable the split menu and go back to the 1.6.0 functionality for the menu. Can you provide an option in the config file to disable the split menu feature?

Enh: On small screens and on scrolling down, the top and bottom menus are hidden (this feature can be disabled in the configuration file)

How do we disable this feature in the configuration file?

If these items can be addressed, we are excited to move to 1.7.0 and I think others will also appreciate this too.

I do appreciate the work you put into making a really great theme. Your theme should be the default for all installs.