Giter Site home page Giter Site logo

humhub-modules-clean-theme's People

Contributors

felixhahnweilheim avatar marc-farre avatar sebmennetrier avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

humhub-modules-clean-theme's Issues

Space title hard to read when banner image in use

When using a background image in the Space header, the Space title becomes unreadable quickly as the font color is set to #76838f - a light grey which has little contrast to mixed-color images.

I can think of a few options

  1. Auto-detected background color to adjust font color to a high contrast
  2. Create an additional layer in-between the image and the text to blur the image colors
  3. Find a high-contrast font color - which might be impossible
  4. Add a text-shadow that has a high contrast to the font color

None of the solutions feel clean and/ or easy enough to propose as solution, hence the full listing of ideas.

CSS border attribute inconsistent for user thumbnails

The visual for user thumbnail is formatted inconsistently.

In the Space members view, a user thumbnail defines border: 1px solid #21A1B3;, which results in the following visual
image

In other places the border attribute is not defined, resulting in
image

The places I could identify so far

  • Space member widget displays border
  • Latest activities widget does not displays border
  • Profile menu (top right) does not display border
  • Stream does not display borders
  • People directory does not display borders

Personally speaking the border provides a little bit of visual boundary and makes for smoother visuals. The metaphor of a picture frame comes to mind. I would prefer a darker color over the
greenish one used in the Space member widget.

Not sure though if this matches with the intention of clean for this theme. Please disregard my personal preferences if not.

HumHub 1.15.0-beta.1: Error when disabling theme

HumHub: 1.15.0-beta.1
Clean Theme Module: 1.5.0

When I activate the clean-theme module and deactivate it right after, I get the following error.
Probably because module disabling is now done in a background job. So the theme views are still active but the module is not available.
The error disappeary after the background job has finished.

yii\base\ErrorException: Attempt to read property "collapsibleLeftNavigation" on null in /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/modules/clean-theme/themes/clean-base/views/ui/menu/widgets/views/left-navigation.php:25
Stack trace:
#0 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/modules/clean-theme/themes/clean-base/views/ui/menu/widgets/views/left-navigation.php(25): yii\base\ErrorHandler->handleError()
#1 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(347): require('...')
#2 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(257): yii\base\View->renderPhpFile()
#3 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(156): yii\base\View->renderFile()
#4 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Widget.php(249): yii\base\View->render()
#5 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/modules/ui/menu/widgets/Menu.php(91): yii\base\Widget->render()
#6 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/components/Widget.php(63): humhub\modules\ui\menu\widgets\Menu->run()
#7 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/modules/admin/views/layouts/main.php(10): humhub\components\Widget::widget()
#8 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(347): require('...')
#9 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(257): yii\base\View->renderPhpFile()
#10 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/View.php(156): yii\base\View->renderFile()
#11 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/components/Controller.php(144): yii\base\View->render()
#12 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Controller.php(408): humhub\components\Controller->renderContent()
#13 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/humhub/modules/admin/controllers/ModuleController.php(65): yii\base\Controller->render()
#14 [internal function]: humhub\modules\admin\controllers\ModuleController->actionList()
#15 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array()
#16 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Controller.php(178): yii\base\InlineAction->runWithParams()
#17 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Module.php(552): yii\base\Controller->runAction()
#18 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/web/Application.php(103): yii\base\Module->runAction()
#19 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/protected/vendor/yiisoft/yii2/base/Application.php(384): yii\web\Application->handleRequest()
#20 /var/www/vhosts/hahn-felix.de/dev.hahn-felix.de/index.php(25): yii\base\Application->run()
#21 {main} 

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.