cyberarbitarge/binance.rs

binance rust connector

binance.rs's Issues

Rest interface proc-macro to reduce the builder implementation redundancy

At a glance, the template code is below

#[derive(Debug, RestApi, Default)]
#[rest(uri="rest_api/path")
#[rest(method="GET")
#[rest(signature="USER_DATA")]
pub struct SomeRestApiName {
        // we belive that every field should implement the Default trait as default value 
        // else use Option as optional semantic
        field1: String,
        field2: Option<i32>,
        // other fields
}

Then we should get the api class with builder as below:

impl RestApi for SomeRestApiName {
         fn uri(&self) -> String { // return the uri in attribute }
         fn method(&self) -> reqwest::Method { // return the method in attribute }
         fn wait_to_sign(&self) -> Option<String> {
                    // hmacsha256 for USER_DATA in binance defined
         }
         fn query() -> Option<String>
         fn body() -> Option<String>
        
}

impl SomeRestApiName {
       pub fn new() -> Self; // Default ?
       pub fn field1(mut self, type) -> Self;
       pub fn field2(mut self, type) -> Self; 
}

So we could use this directly in Client look like this

async fn main() {
      async {
              let mut request = SomeRestApiName::new()
                                            .field1(xxxx)
                                            .field2(xxx);
             client.execute(&request).unwrap();
      }
}

• introduce the proc_macro crate for describe this issue
• full-test for anything