cyberpunkmetalhead/binance-news-sentiment-bot

This is a fully functioning Binance trading bot that takes into account the news sentiment for the top 100 crypto feeds. If you like this project consider donating though the Brave browser to allow me to continuously improve the script.

binance-news-sentiment-bot's Issues

'NoneType' object has no attribute 'encode

I know there is an error abt that but any solution? I'm using real keys, not test.
preparing to buy 3.72 XRP with USDT at 1.34310000 'NoneType' object has no attribute 'encode' Sentiment not positive enough for BTC, or not enough headlines analysed or already bought: 0.0170875, 8 preparing to buy 0.00184 ETH with USDT at 2718.69000000 'NoneType' object has no attribute 'encode'
Inserted the keys. have balance. Testnet set to false.
python-binance library updated.

Add license details

BCHUSDT Error for Binance API

Looks like the Binance API is returning a Symbol error when trying to place a trade on BCHUSD via the testnet. If anyone has encountered this issue before and has a workaround, please let me know.

No output

Unlike other issues, I have run the script with nothing displayed so far in the Gitbash window. I tried including some print statements in-between functions just to know which functions are executed but nothing. Even the print statement below the if _name=='main' does not execute.

Note: The only change I made to the original script are the environment variables plus importing the ThreadedWebSocketManager from binance i.e, from binance import ThreadedWebsocketManager` Apart from that everything is the same

The output is nothing

RuntimeError('Event loop is closed') when starting article loop

It only happens on a few times then continues on normally

Iteration 7
Exception ignored in: <function _ProactorBasePipeTransport.__del__ at 0x000001BC9655F9D0>
Traceback (most recent call last):
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 746, in call_soon
    self._check_closed()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
Exception ignored in: <function _ProactorBasePipeTransport.__del__ at 0x000001BC9655F9D0>
Traceback (most recent call last):
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 746, in call_soon
    self._check_closed()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
Exception ignored in: <function _ProactorBasePipeTransport.__del__ at 0x000001BC9655F9D0>
Traceback (most recent call last):
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 746, in call_soon
    self._check_closed()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
Exception ignored in: <function _ProactorBasePipeTransport.__del__ at 0x000001BC9655F9D0>
Traceback (most recent call last):
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 746, in call_soon
    self._check_closed()
  File "C:\Users\Blake\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

Not Able to Buy: AttributeError: 'NoneType' object has no attribute 'encode'

Getting the following error:

preparing to buy 0.001996 BTC with USDT at 50112.05000000
Traceback (most recent call last):
  File "/Users/rami/scripts/Binance-News-Sentiment-Bot/news-analysis.py", line 489, in <module>
    buy(compiled_sentiment, headlines_analysed)
  File "/Users/rami/scripts/Binance-News-Sentiment-Bot/news-analysis.py", line 389, in buy
    test_order = client.create_test_order(symbol=coin+PAIRING, side='BUY', type='MARKET', quantity=volume[coin+PAIRING])
  File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 1723, in create_test_order
    return self._post('order/test', True, data=params)
  File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 323, in _post
    return self._request_api('post', path, signed, version, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 265, in _request_api
    return self._request(method, uri, signed, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 243, in _request
    kwargs['data']['signature'] = self._generate_signature(kwargs['data'])
  File "/usr/local/lib/python3.9/site-packages/binance/client.py", line 198, in _generate_signature
    m = hmac.new(self.API_SECRET.encode('utf-8'), query_string.encode('utf-8'), hashlib.sha256)
AttributeError: 'NoneType' object has no attribute 'encode'```

Sell asset error

Binance-News-Sentiment-Bot/news-analysis.py

Line 405 in 10dc4e8

test_order = client.create_test_order(symbol=coin+PAIRING, side='SELL', type='MARKET', quantity=coins_in_hand[coin]*99.5/100 )

When coins_in_hand[coin] goes to small, and binance will reject sell order for asset.

BTC: 0.046819 * 99.5 / 100 = 0.046584905, it has 9 decimal places.

Could not parse ... messages

I am getting the following:

Could not parse https://ethereumworldnews.com/feed/ error is: Server disconnected
Could not parse http://infoonbitcoin.com/feed/ error is: Server disconnected
Could not parse https://about.crunchbase.com/blog/feed/ error is: Cannot connect to host about.crunchbase.com:443 ssl:default [None]
Could not parse https://vaultoro.com/feed/ error is: [Errno 32] Broken pipe
Could not parse https://bitcoinspakistan.com/feed/ error is: [Errno 32] Broken pipe
Could not parse https://blog.purse.io/feed error is: [Errno 32] Broken pipe
Could not parse https://blog.feedspot.com/feed/ error is: Server disconnected
Could not parse https://www.goldsilveranalyst.com/feed error is: Server disconnected
Could not parse https://coinjournal.net/feed/ error is: [Errno 32] Broken pipe
Could not parse https://www.crypnotic.com/blog/feed error is: [Errno 32] Broken pipe
Could not parse https://coinpress.io/feed/ error is: [Errno 32] Broken pipe
Could not parse https://www.crypto-news.net/feed/ error is: [Errno 32] Broken pipe
Could not parse https://www.cryptostache.com/feed/ error is: [Errno 32] Broken pipe
Could not parse https://decrypt.co/feed error is: [Errno 32] Broken pipe

I can open the files using a browser, sounds like bad plumbing on their side.

Also:

Could not parse https://botsfolio.com/crypto_news/feed error is: 'NoneType' object has no attribute 'text'

Could not parse http://www.investorideas.com/rss/feeds/iimain.xml error is: time data 'Fri, 23 Apr 2021 14:10:00 EST' does not match format '%a, %d %b %Y %H:%M:%S %z'
Maybe support multiple date formats?

Typo in project description

Functionting should be functioning

Program freezes when order is timed out.

preparing to buy BTC with 0.001829 USDT at 54668.42000000

binance.exceptions.BinanceAPIException: APIError(code=-1021): Timestamp for this request is outside of the recvWindow.

Code freeses when order is timed out.
Suggesting adding a continue statement when:
BinanceAPIException raises
BinanceOrderException raises

replace "coins_in_hand" with "get_asset_balance"

i think it would be better to directly read available coins balance from wallet

balance = client.get_asset_balance(asset='BTC')

sleeping time

Hi, thank you for providing this code! I realize you said the script is running every 60 minute in reddit but in coding time.sleep()is taking 60 seconds right now. Is this intended to run script every 60 seconds for testing?

requirements.txt also needs aiohttp==3.7.4

Event Loop Is Closed

First off I want to thank you for providing this code!

I'm currently having 2 issues, after it goes to "buy" i have a range of traceback errors

Then it tells me I have insufficient balance, I've changed the quantity in the code down to 15 to see if that would work but it doesn't. I've checked binance i do have £30 deposited and a further 15 already in coins.

Any suggestions would be greatly appreciated!

Regards,

For loop in buy doesn't seem to run properly

After some more testing it looks like there's an issue with the for loop inside the buy function.

Below you can see there are 3 coins in the compiled_sentiment though the bot only places a trade for XRP.
According to the current logic, the bot should also print a notification saying that the BTC and ETH sentiment or headline volumes are not high enough. Currently working on a fix, but please let me know if you have a solution.

{'XRP': 0.1695, 'BTC': -0.026232, 'ETH': 0.18693333333333337, 'BNB': 0.0} preparing to buy 75.7 XRP with USDT at 1.32147000 order 4343 has been placed on XRP with 75.70000000 at 2021-04-18 20:03:19.198000 and bought at 1.32063000

'NoneType' object has no attribute 'encode

create test order before pushing an actual order

        test_order = client.create_test_order(symbol=coin+PAIRING, side='BUY', type='MARKET', quantity=volume[coin+PAIRING])

over in this line im getting error message "'NoneType' object has no attribute 'encode", while it says preparing to buy xxx with USDT at xxx price.

Can help help me solve this issue?

Thanks.

Could not parse error

When running the code, the headlines of some pages are not being parsed (like 37/103 pages are actually being parced)
the error says:
"Could not parse "www.examplepage.com/feed" error is: "
(doesn't say what the error is, it just says there's an error)

When i click those links i just see some code, i tried openning the pages in different browsers but always return code.

(sorry for writing this here but idk if this is against any /r/bitcoin rules)

DOGEUSDT

getting following error when buying DOGE

Traceback (most recent call last): File "D:\Downloads\Schneider\ScriptingPath\Crypto\Binance-News-Sentiment-Bot-main\news-analysis.py", line 447, in buy(compiled_sentiment, headlines_analysed)
File "D:\Downloads\Schneider\ScriptingPath\Crypto\Binance-News-Sentiment-Bot-main\news-analysis.py", line 348, in buy test_order = client.create_test_order(symbol=coin+PAIRING, side='BUY', type='MARKET', quantity=volume[coin+PAIRING])
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 1633, in create_test_order return self._post('order/test', True, data=params)
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 295, in _post return self._request_api('post', path, signed, version, **kwargs)
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 242, in _request_api return self._request(method, uri, signed, **kwargs)
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 220, in _request kwargs['data']['signature'] = self._generate_signature(kwargs['data'])
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 175, in _generate_signature m = hmac.new(self.API_SECRET.encode('utf-8'), query_string.encode('utf-8'), hashlib.sha256)
AttributeError: 'NoneType' object has no attribute 'encode'

Error while placing order in Testnet

Press Ctrl-Q to stop the script
Kraken Daily Market Report for April 25 2021
OKEx Insights + Catallact : Bitcoin Market Witness the Growth of Retail Participation as Institutional Investors Continue to Lead
Bitcoin Banned in Turkey | This Week in Crypto – Apr 26, 2021
Mercurial on crypto: Will India’s latest stance lead to positive regulation?
OneLedger Announces “Gem Hunt” Mining and Validator Competition
AMA with Harsh Rajat and Richa Joshi (EPNS): Summary
Blockchain Object Storage Company Filebase Raises $2M, Aims to Incorporate Filecoin and Arweave Networks
Why Are Athletes Demanding To Be Paid In Bitcoin?
Could not parse http://Bitcoinist.com/feed error is: unbound prefix: line 57, column 2
Unmarshal's MARSH token lists on AscendEX
A Glimpse Into The Future Of Bitcoin At $200,000
Giant American Wine Seller Now Accepts Bitcoin, Dogecoin, and Ethereum
Verifying your 2FA disable requests and other security tips from CEX.IO
Embrace the Explosion of Colors in the Festive Hot Fiesta Slot
Could not parse https://www.mycryptopedia.com/feed/ error is: mismatched tag: line 135, column 2
Ampleforth.org Airdrop Review: The FORTH token has arrived
Stellar Lumen (XLM) Price Primed For A Fresh Rally Above $0.45
XRP Price Analysis: XRP Continues To Fall As Price is Stuck In Descending Channel
Turkey’s Central Bank: Crypto Regulation Will Come In Two Weeks
Dogecoin [DOGE] Struggles Near Support Despite An Uptick of 5%
Solana Hits All-Time High Amid Market Calm
Bit-flash.biz Review: PAYING or SCAM?
Could not parse https://botsfolio.com/crypto_news/feed error is: 'NoneType' object has no attribute 'text'
Nem szeretnek adót fizetni a multik – több milliárd dollár kötött ki adóparadicsomokban
Satoshi Nakamoto Identity Case Takes a New Turn
Could not parse http://bitcoinmxn.com/feed error is: 'NoneType' object has no attribute 'text'
Crypto News Cast For April 25th 2021 ?
XRP Ripple Returns – Long ETH and XRP
OKEx Insights + Catallact : Bitcoin Market Witness the Growth of Retail Participation as Institutional Investors Continue to Lead
Bitmain Teasing With the Upcoming AntMiner E9 Ethereum Miner
Top 5 Peterborough United F.C. Forums, Discussions and Message Boards You Must Follow in 2021
Neo Price Analysis: NEO Breaks Downtrend as Bulls Target $100
Could not parse https://coinpress.io/feed/ error is: 'charmap' codec can't decode byte 0x9d in position 22517: character maps to <undefined>
More Projects joining Polygon (MATIC) amidst rising Layer-2 adoption
Apple, MicroStrategy and Microsoft Stock Tokens Are Coming To Binance
Could not parse http://www.investorideas.com/rss/feeds/iimain.xml error is: time data 'Fri, 23 Apr 2021 14:10:00 EST' does not match format '%a, %d %b %Y %H:%M:%S %z'
How to Buy Real Estate with Cryptocurrency?
Traceback (most recent call last):
  File "D:/FinanceRepos/Binance-News-Sentiment-Bot/news-analysis.py", line 473, in <module>
    buy(compiled_sentiment, headlines_analysed)
  File "D:/FinanceRepos/Binance-News-Sentiment-Bot/news-analysis.py", line 368, in buy
    test_order = client.create_test_order(symbol=coin + PAIRING, side='BUY', type='MARKET',
  File "D:\Anaconda3\envs\pyt12\lib\site-packages\binance\client.py", line 1633, in create_test_order
Time it took to parse feeds:  24.928550800000004

BUY CHECKS:
Sentiment not positive enough for XRP, or not enough headlines analysed or already bought: -0.125, 2
preparing to buy 0.001876 BTC with USDT at 53294.93000000
    return self._post('order/test', True, data=params)
  File "D:\Anaconda3\envs\pyt12\lib\site-packages\binance\client.py", line 295, in _post
    return self._request_api('post', path, signed, version, **kwargs)
  File "D:\Anaconda3\envs\pyt12\lib\site-packages\binance\client.py", line 242, in _request_api
    return self._request(method, uri, signed, **kwargs)
  File "D:\Anaconda3\envs\pyt12\lib\site-packages\binance\client.py", line 220, in _request
    kwargs['data']['signature'] = self._generate_signature(kwargs['data'])
  File "D:\Anaconda3\envs\pyt12\lib\site-packages\binance\client.py", line 175, in _generate_signature
    m = hmac.new(self.API_SECRET.encode('utf-8'), query_string.encode('utf-8'), hashlib.sha256)
AttributeError: 'NoneType' object has no attribute 'encode'

Got this error, i have the API keys as mentioned in the blog, can you tell me what might be the issue here?

news export

hello sir, thanks for share this excelent code, i may ask you how can i export the news from the scapper to a database for example or a csv, im trying to make it but i was not able to make it.

Exclude articles after defined time has past

Here's how I implemented it:
Add timezone to datetime import

# define how old an article can be to be included
# in hours
HOURS_PAST = 24

# convert pubDat to datetime
published = datetime.strptime(pubDate.replace("GMT", "+0000"), '%a, %d %b %Y %H:%M:%S %z')
# calculate timedelta
time_between = datetime.now(timezone.utc) - published

if (time_between.total_seconds() / (60 * 60) <= HOURS_PAST):

Add ^ before the following...

Binance-News-Sentiment-Bot/news-analysis.py

Lines 224 to 230 in 56da3d1

	# append the source
	headlines['source'].append(feed)
	# append the publication date
	headlines['pubDate'].append(pubDate)
	# append the title
	headlines['title'].append(title)
	print(channel)

No module named 'binance.websockets'

Hi, first of all thank you very much for your work!
I have tried to set up the bot, I installed everything and modified the settings in the console but I get this error when I try to run the bot:

root@vultr:~/Binance-News-Sentiment-Bot# python3 -m news-analysis
Traceback (most recent call last):
File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/root/Binance-News-Sentiment-Bot/news-analysis.py", line 34, in
from binance.websockets import BinanceSocketManager
ModuleNotFoundError: No module named 'binance.websockets'

sWhat do you suggest I do? Thanks in advance

vader_lexicon issue?

---

Resource vader_lexicon not found.
Please use the NLTK Downloader to obtain the resource:

import nltk
nltk.download('vader_lexicon')

For more information see: https://www.nltk.org/data.html

Attempted to load sentiment/vader_lexicon.zip/vader_lexicon/vader_lexicon.txt

Searched in:
- '/root/nltk_data'
- '/usr/nltk_data'
- '/usr/share/nltk_data'
- '/usr/lib/nltk_data'
- '/usr/share/nltk_data'
- '/usr/local/share/nltk_data'
- '/usr/lib/nltk_data'
- '/usr/local/lib/nltk_data'
- ''

---

'could not parse' error

an example would be:
Could not parse https://www.coin.space/feed/ error is:
this happened on google colab, and my own machine (ubuntu 18.04, python3.7.10). most of the news source it cannot parse at this moment, which is kinda worrying.
thanks.

bot will work well in the 1st iteration....

During the read article loop, if the articles are not changed....then you will probably buy (or sell) coins until you are out of money or out of coins....this means that using this bot at its current stage is not recommended.

Suggest:

1. Set a maximum limit at first.
2. Mark whether you reacted to the articles or not.

add "find_lot_size" for sell order too

APIError(code=-2015): Invalid API-key, IP, or permissions for action.

I know this one seems obvious but nothing I have done has worked... This is all on binance.us

The bot works fine for testnet but when I switch to live I get this error (using small test values to see if it will execute at all):

I set 'testnet' to 'False and I have tried both setting the environment variables on windows to the api key/secret as well as copying and pasting it directly as a string like this:

api_key_live = "randomapikeycharacters"
api_secret_live = "randomapikeycharacters"

I tried generating a new api key and switching some settings around but nothing seemed to work and don't know what else to try. Does anyone have live trades working on binance.us?

use simplier market orders ?

USE

order = client.order_market_buy(
symbol='BNBBTC',
quantity=100)

INSTEAD OF

buy_limit = client.create_order(
symbol=coin+PAIRING,
side='BUY',
type='MARKET',
quantity=volume[coin+PAIRING]
)

ETHUSDT

when buying ETH
Traceback (most recent call last):
File "D:\Downloads\Schneider\ScriptingPath\Crypto\Binance-News-Sentiment-Bot-main\news-analysis.py", line 447, in
buy(compiled_sentiment, headlines_analysed)
File "D:\Downloads\Schneider\ScriptingPath\Crypto\Binance-News-Sentiment-Bot-main\news-analysis.py", line 348, in buy
test_order = client.create_test_order(symbol=coin+PAIRING, side='BUY', type='MARKET', quantity=volume[coin+PAIRING])
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 1633, in create_test_order
return self._post('order/test', True, data=params)
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 295, in _post
return self._request_api('post', path, signed, version, **kwargs)
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 242, in _request_api
return self._request(method, uri, signed, **kwargs)
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 237, in _request
return self._handle_response()
File "D:\Program_files\Python\Python39\lib\site-packages\binance\client.py", line 285, in _handle_response
raise BinanceAPIException(self.response)
binance.exceptions.BinanceAPIException: APIError(code=-1013): Filter failure: LOT_SIZE