Comments (2)
Adding vertical-align: bottom
to the Bullet solves the issue but breaks multiline thoughts.
We need to align the Bullet with the first line of the thought.
-
Align to top and move down- Depends on height of
ContextBreadcrumbs
- Depends on height of
-
Align to bottom and move up- Depends on height of
Thought
- Depends on height of
- Align to top of new div that wraps
Thought
.
Commit: aec1198
diff --git a/src/App.css b/src/App.css
index bcc420ef66..e1388b2422 100644
--- a/src/App.css
+++ b/src/App.css
@@ -1088,12 +1088,6 @@ h1 .num-contexts {
padding: 0.2em 0 0.2em 100px;
}
-/* In context view, make room for breadcrumbs. */
-.child.show-contexts > .thought-container .bullet {
- position: relative;
- top: 1.4em;
-}
-
.child > .thought-container > .bullet .glyph {
position: relative;
/*margin-right: 10px; this causes the li to break at the beginning with longer text */
diff --git a/src/components/Bullet.tsx b/src/components/Bullet.tsx
index f2276781fa..e3a4f6cccb 100644
--- a/src/components/Bullet.tsx
+++ b/src/components/Bullet.tsx
@@ -156,6 +156,8 @@ const Bullet = ({
})}
style={{
marginLeft: bulletMarginLeft,
+ // align bullet to thought even if ContextBreadcrumbs is multiple lines
+ verticalAlign: 'bottom',
}}
>
from em.
Test Case:
- a
- m
- x
- b do it for your country
- c do it for your country
- d do it for your country
- everything everywhere all at once everything everywhere all at once everything everywhere all at once
- m
- y
from em.
Related Issues (20)
- Context View: Nested grandchildren not rendered
- Draw gesture visual feedback HOT 2
- Service Worker
- Gesture Palette
- Thought not re-rendered after attributes load HOT 1
- Fix drop target positioning
- Consolidate z-index
- Fix cursor overlay bullet on pending thought
- Welcome screen is shown after restart
- Drag false positive after startup
- Lexeme loaded after delete
- Gesture Autocomplete HOT 1
- [iOS PWA]: Scroll cursor into view does not work when at top of screen HOT 1
- Shared fetch queue for prioritized pulls HOT 1
- Add tests for multiline cursor/selection movement
- [PWA] Long press to select incorrectly activated when scrolled HOT 2
- Autofocus not updating HOT 1
- Render Performance HOT 2
- Safari incorrectly wraps "Rendered a machine" at certain font sizes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from em.