Giter Site home page Giter Site logo

Comments (2)

raineorshine avatar raineorshine commented on June 12, 2024

Adding vertical-align: bottom to the Bullet solves the issue but breaks multiline thoughts.

We need to align the Bullet with the first line of the thought.

  • Align to top and move down
    • Depends on height of ContextBreadcrumbs
  • Align to bottom and move up
    • Depends on height of Thought
  • Align to top of new div that wraps Thought.

Commit: aec1198

diff --git a/src/App.css b/src/App.css
index bcc420ef66..e1388b2422 100644
--- a/src/App.css
+++ b/src/App.css
@@ -1088,12 +1088,6 @@ h1 .num-contexts {
   padding: 0.2em 0 0.2em 100px;
 }

-/* In context view, make room for breadcrumbs. */
-.child.show-contexts > .thought-container .bullet {
-  position: relative;
-  top: 1.4em;
-}
-
 .child > .thought-container > .bullet .glyph {
   position: relative;
   /*margin-right: 10px;    this causes the li to break at the beginning with longer text */
diff --git a/src/components/Bullet.tsx b/src/components/Bullet.tsx
index f2276781fa..e3a4f6cccb 100644
--- a/src/components/Bullet.tsx
+++ b/src/components/Bullet.tsx
@@ -156,6 +156,8 @@ const Bullet = ({
       })}
       style={{
         marginLeft: bulletMarginLeft,
+        // align bullet to thought even if ContextBreadcrumbs is multiple lines
+        verticalAlign: 'bottom',
       }}
     >

from em.

raineorshine avatar raineorshine commented on June 12, 2024

Test Case:

- a
  - m
    - x
- b do it for your country
  - c do it for your country
    - d do it for your country
      - everything everywhere all at once everything everywhere all at once everything everywhere all at once
        - m
          - y

from em.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.