cyberzhg/keras-pos-embd

Position embedding layers in Keras

keras-pos-embd's Issues

维度不一致，相加报错

add模式下，多个不同维度的输入，共用一个PositionEmbedding时，将会报错。因为相加时，PositionEmbedding的维度不可能既满足第一个输入的加法，又满足第二个输入的加法。

或许133行可以改为
inputs + pos_embeddings[:,:,:output_dim]
或者
把129行第二个self去掉
但改129行应该会影响其他模式

小白飘过，看大神怎么改法

ValueError: Unknown layer: TrigPosEmbedding

Any idea how to fix it? there was no any problem during the training process but this error came out when i tried to load the model, thx!

Confusion regarding using other embeddings

Note that you don't need to enable mask_zero if you would concatenate other layers like word/Char embeddings with masks
Can you please explain this or give a snippet that illustrates what you mean.... for example, what if I want to user vanilla Keras embedding layer
@CyberZHG

Input to the position embedding model

Hi CyberZHG,

I want to use this position embedding in an existing model. Can I add this as a layer to the existing model? Another doubt is how to give the relative postions vector to this embedding model.

当我使用tensorflow2.1和keras2.3.1时，代码不能正常运行