cyclopsmc / integratedrest Goto Github PK

View Code? Open in Web Editor NEW

17.0 17.0 4.0 2.52 MB

Expose Integrated Dynamics networks as a REST API

License: MIT License

Java 99.84% Shell 0.16%

forge hacktoberfest java minecraft

integratedrest's People

Stargazers

Watchers

Forkers

josephcsible otakup0pe waoweens thunfisch987

integratedrest's Issues

How to find the @ID in the REST webpage based on the variable card ID?

Issue type:

❓ Question

Question:

I set up a variable card, its ID is 10, Part ID is 20, and its value is 822.
xyz is also the same as the one in the game, I just made sure this is my variable card ID.

I found the json with "value"=822 in the "http://localhost:3000/networkElement" webpage, showing @id = 19.
I want to know if there is an accurate way for me to find the @id on the webpage through the variable card ID

java.net.BindException: Address already in use: bind

Issue type:

🐛 Bug

Short description:

it crashes

Steps to reproduce the problem:

...Create a new world

Expected behaviour:

to not crash

Versions:

This mod: 1.1.1
Minecraft: 1.12.2
Forge: 14.23.5.2847

Log file:

https://paste.dimdev.org/ujotinigal.mccrash

Exception in server tick loop Address already in use

Issue type:

🐛 Bug

Causing server tick loop when loaded as part of the Encrypted_ Modpack

See crash reports, log and debug log

Boot Server with encrypted_ modpack in a linux environment (windows untested)
(SP windows works fine)

IntegratedREST-1.18.2-1.1.5

This mod: IntegratedREST-1.18.2-1.1.5
Minecraft: 18.2
Forge: 40.1.74

Reported to modpack author as well.
latest.txt

debug excert.txt

crash-2022-08-28_17.46.45-server.txt

voiding variable store

Issue type:

🐛 Bug

Short description:

i put variable carts to variable store while playing with http proxy, trying to get some logic with it. while putting cards into variable store, they aren't visible in system(proggrammed cards do not work), and they dissaper.and it crashed in 3 try to get it work and my test world is corrupted.

Steps to reproduce the problem:

create number card from http proxy
create integer card in proggramer
create equals logic.
put that card in some writer
put the cards inside variable storage
play with them
and they will dissapear.
and world can crash

Expected behaviour:

Versions:

This mod:
Minecraft:
Forge:

Log file:

Token/password protected http proxy

Issue type:

➕ Feature request

Short description:

Please add an option to protect with password, token or whatever, so you can send requests with a second parameter for this basic auth(still better than nothing), so other people cant break you systems, by sending random http requests.

(I just want to make a reactor controller app for android, would be so much satisfaction to do, pls add)

Get multiple data per requests

Issue type:

❓ Question

Question:

Hello! I'm having a lot of fun building up my API, but one massive issue is that I need (AFAIU) to build a proxy block + a variable card for each values I want to GET, and then GET them separatly.
I was wondering if it was possible to GET a reader block directly and retrieve a JSON containing all the variables that reader has.
I know it's possible to query a reader but it just retrieves generics info about it and no values. Am I missing something?

Thanks lot !

Server crashes on Post request, works in SP

Issue type:

🐛 Bug

Short description:

I built the proxy. I took a bunch of attempts to post a variable to it, but it worked.
Then I switched it to "any" type, tried it again, but every time since then it caused the server to crash (Due to timeout (60s Tick)).

I downloaded the world and loaded it in single player (changed my URL to localhost) and ran it without issue.

Steps to reproduce the problem:

Note: I am pretty sure this is not enough to recreate the bug in any world, but I don't have the resources to try

Start server
Send POST request
Game crashes

Expected behaviour:

Variable updates like first time/in SP.

Versions:

This mod: 1.1.10
Minecraft: 1.20.1
Forge: 47.2.17

I will try to recreate this issue with a smaller set of mods if I have the time.
However, for now I want to note that when trying to GET some data, they did not load/took incredibly long to load (most prominently, the networkElement subpage). The biggest network on the server is around 90 cables and probably 25 connected elements in case that may be the issue.

Total stats:
Number of networks: 8
Sum of all cables: 169
Sum of elements: 86

Log file:

https://pastebin.com/A6nZD3Mk

Again, sorry for not having the smallest mod subset, I'm very pressed for time atm and the main priority was to get the Server back up and running.

Run LDN spec tests

Issue type:

❓ Question

Question:

I could not tell whether the tooling supports Linked Data Notifications or not. It briefly mentions it in https://github.com/CyclopsMC/IntegratedREST/wiki/HTTP-POST-requests and there appears to be an inbox assignment to a target resource in source code.

If the application fulfills (or plans to) sender, receiver, or consumer roles, it'd be great to see it pass the tests at https://linkedresearch.org/ldn/tests/ - so that we can see it at https://linkedresearch.org/ldn/tests/summary :)

How i can extract only one value?

Issue type:

❓ Question

Question:

i wan´t terminal to not print whole json, but only one value. i try to found it for hours.
i have simple setup with one redstone reader, and i want to get only the signal strengh. not loads of things like position, value type... in terminal.

Exception running with various mods on 1.19.2.

Issue type:

🐛 Bug

Short description:

Upon adding Integrated REST to my modpack, Minecraft crashes as startup with the following exception:

Exception in thread "main" java.lang.module.ResolutionException: Modules integratedrest and io.netty.resolver export package io.netty.resolver to module mekanism
	at java.base/java.lang.module.Resolver.resolveFail(Resolver.java:901)
	at java.base/java.lang.module.Resolver.failTwoSuppliers(Resolver.java:815)
	at java.base/java.lang.module.Resolver.checkExportSuppliers(Resolver.java:736)
	at java.base/java.lang.module.Resolver.finish(Resolver.java:380)
	at java.base/java.lang.module.Configuration.<init>(Configuration.java:140)
	at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:494)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.ModuleLayerHandler.buildLayer(ModuleLayerHandler.java:75)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.TransformationServicesHandler.buildTransformingClassLoader(TransformationServicesHandler.java:60)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:104)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:77)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141)

The modules range from Mekanism to Caelus API to Dismount Entity (those I've observed so far, seems random each time I load). Integrated REST appears to be the common cause.

Steps to reproduce the problem:

Add Caelus API, Dismount Entity or Mekanism mods along with Integrated REST (and it's requirements).
Observe exception on startup.

Expected behaviour:

Minecraft should load without crashing.

Versions:

This mod: 1.1.6
Minecraft: 1.19.2
Forge: 43.1.3
Mekanism: 10.3.3.470
Dismount Entity: 1.8
Caelus API: 3.0.0.6

Log file:

https://pastebin.com/AwkxXfym

Rest block crashes on inserting a blank variable card

Issue type:

🐛 Bug

Short description:

Rest block crashes on inserting a blank variable card

Steps to reproduce the problem:

Above

Expected behaviour:

Whatever the mod is supposed to do

Versions:

This mod: IntegratedREST-1.19.4-1.1.8.jar
Minecraft: client-1.19.4
Forge: forge-1.19.4-45.0.55

Log file:

https://pastebin.com/dqXRTVq3

Variables referencing HTTP variables do not get updated

Issue type:

🐛 Bug

Steps to reproduce the problem:

1.Place a HTTP Proxy, select some variable type (such as boolean), and put a variable inside so the variable is linked up with the proxy.
2. Do some computation with the previous variable and get a new variable.
3. Insert the HTTP variable and the new variable into separate screens to monitor their value.
4. Update the HTTP variable by sending something in Postman, Python, or whatever.
5. The HTTP variable gets updated, but the variable referencing it does not.

Expected behaviour:

Variables referencing HTTP variables are updated when the referenced variables are updated via HTTP requests.

Versions:

This mod: 1.1.4
Minecraft: 1.16.5
Forge: 36.2.0

Log file:

Cannot GET from a display panel when the variable card inside it has NBT data

Issue type:

🐛 Bug

Short description:

When you put a variable card that contains NBT data inside a display panel, the display panel's /part page will refuse to load.

Steps to reproduce the problem:

Place a chest
Place a block reader facing the chest
Connect the block reader and a display panel to a HTTP Proxy
Apply "Tile Entity NBT" (from the block reader) to a variable card
Place variable card inside display panel
Open http://localhost:3000/networkElement/integrateddynamics/part/# in your browser (replace # with your display panel's part number)
See that the page does not load

Expected behaviour:

Page loads and the NBT data is there.

Versions:

Common Capabilities: 1.16.5-2.7.0
Cyclops Core: 1.16.5-1.11.9
Integrated Dynamics: 1.16.5-1.9.4
Integrated REST: 1.16.5-1.1.3
Minecraft: 1.16.5
Forge: 36.2.4

Log file:

https://gist.github.com/Waoweens/ecdd05f7c8f157c0ab2d3ae5abfee366

SP Game crash when running server

Issue type:

🐛 Bug

Short description:

The game will crash when running this mod if there is a minecraft server running with the mod as well due to both of them trying to use the default port.

Steps to reproduce the problem:

Make a forge 1.16.5 server with this mod
Run a client with this mod
Try to join a local world

Expected behaviour:

The game should give a warning (maybe in chat) about not being able to bind the port, but not crash. On servers, it should print an error message to the console, but not crash.

Versions:

This mod: 1.1.3
Minecraft: 1.16.5
Forge: 36.1.4

Log file:

https://pastebin.com/SMRPqqwR

How to get data

Issue type:

❓ Question

Question:

how i can get data from network, for example, from redstone reader?

Server process does not stop

Issue type:

🐛 Bug

Short description:

The server process does not exit after the stop command has been run and saving completed.

Modlist:
CommonCapabilities-1.16.4-2.5.5.jar
CyclopsCore-1.16.4-1.9.3.jar
IntegratedDynamics-1.16.4-1.1.21.jar
IntegratedREST-1.16.4-1.1.1.jar

Default configs

I left the server in the half-stopped state for over 7 hours with no change.

Steps to reproduce the problem:

Install the mod
Start the server (existing or new world)
Stop the server

Expected behaviour:

Server process to exit after saving has been completed.

Versions:

This mod: 1.16.4-1.1.1
Minecraft: 1.16.4
Forge: 1.16.4-35.1.28
Also tested on forge 35.1.13

Log file:

https://pastebin.com/hP25kxZ1 Nothing out of the ordinary

Add Access-Control-Allow-Origin header to response

Issue type:

➕ Feature request

Short description:

I am trying to GET from a part (using fetch) but the browser seems to block it because of CORS.
Adding the Access-Control-Allow-Origin header to the response should fix this.

Server-only Version

Straightforward request - can we get a version of this mod that doesn't add blocks, and can be run on a server without a client-side mod needing to be installed?

Reason: I see a few modpacks with ID that don't have this mod, and it'd be nice to be able to just drop this in without having to talk users through installing an additional mod.

Recipe and Ingredients support for parity with base InDy

Issue type:

➕ Feature request

Short description:

A quick skim and a Discord conversation have revealed that REST does not provide support for the Recipe and Ingredients base types. I guess these got forgotten about?