cyclopsmc / integratedterminals Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 6.0 13.68 MB

Terminals for managing and overviewing Integrated Dynamics networks

License: MIT License

Java 99.97% Shell 0.03%

forge hacktoberfest java minecraft

integratedterminals's People

Contributors

Stargazers

Watchers

Forkers

trainerredstone7 wiwileborne darkdna shadow7412 nskobelevs anihacc snonky

integratedterminals's Issues

Storage Terminal hangs when crafting

Issue type:

🐛 Bug

Short description:

When attempting to auto craft a display panel from integrated dynamics inside of a storage terminal the terminal would hang at the crafting plan screen showing the message "Calculating crafting plan..." and would never craft the item.

Steps to reproduce the problem:

I was able to reproduce this bug in a fresh instance of minecraft and a fresh world.
I built a storage terminal and connected it to a chest.
I placed a crafting table with a crafting interface on top of it and connected it to the network.
I then made all the recipe cards that are required to craft a display screen and put them into the crafting interface.
I filled the chest with everything it needed to craft a display screen.
When I tried to autocraft a display screen from the storage terminal it hung at the crafting plan menu.
So far I've seen this happen with the display panel and the storage terminal when trying to autocraft them.

Note: If you don't have the required items to craft the display panel then the crafting plan screen works normally and shows you what you are missing.

Expected behaviour:

What normally happens with other recipes is it shows that it has all of the components to craft the item and then you can press the craft button to craft it. If it does not have all the components to craft the item then it shows you what you are missing so you can add it to the network and then try again.

Versions:

This mod: 1.0.1
Minecraft: 1.12.2
Forge: 14.23.5.2768

Log file: https://pastebin.com/LAi2PJLR

Autocrafting can't use more than 64 ingredients.

Issue type:

🐛 Bug

Short description:

When doing a large craft in the crafting terminal it doesn't let you use more than 64 ingredients in the craft. For example if you want to do 100 plank crafts (which comes out to 400 planks) it can't do it because in the crafting plan menu it will say 64 logs stored and below it will say missing 36 logs and it will be unable to craft.

Steps to reproduce the problem:

To reproduce you can just make a new world and setup an autocrafting system and start an autocraft that will require the system to use more than 64 ingredients during the craft.

Expected behaviour:

I expected it to use all my logs to craft any number of planks I tell it to.

Versions:

This mod: 1.0.1
Minecraft: 1.12.2
Forge: 14.23.5.2768

Log file:

https://pastebin.com/FrvQzdDB
(I don't think this log will help? There was no error when the craft failed.)

item pulled from terminal disappears if placed on an inventory slot with other items

Issue type:

🐛 item pulled from terminal disappears if placed on an inventory slot with other items

Short description:

When i pull an item or a stack of items from my terminal and try to place it in an inventory slot that already contains other items, the first item or stack of items disappears.

Steps to reproduce the problem:

1.pull an item from your terminal and place it in your inventory in a slot that already contains items

Expected behaviour:

the new item should occupy the slot in the inventory and the item that was there should end up in your cursor , just like pulling an item from a chest and doing the same thing.

Versions:

IntegratedTerminals-1.12.2-1.0.6
Minecraft 1.12.2
Forge 14.23.5.2781

crafting tab sees recipes as items

Issue type:

🐛 Bug
(interaction with integrated crafting)

Short description:

when on the crafting tab of terminal, any recipe you have makes the terminal assume you actually have it with JEI recipe auto-completion

Steps to reproduce the problem:

set up a simple system consisting of a storage interface, a terminal, and a crafting interface with any valid recipe connected to a valid machine(such as a crafting table) [e.g. sticks]
request an item that uses the recipe's output as part of the recipe [e.g. bow]
make sure all of the other components of the recipe are in the storage [e.g. string]
the autocomplete will be successful but the items from the recipe won't appear in the crafting box, only the actual stored items [e.g. a line of string, but no sticks]

Expected behavior:

it should highlight the missing items [e.g. sticks] instead of showing a successful autocomplete.

Versions:

This mod: 1.0.1
Minecraft: 1.12
Forge: 14.23.5.2781

Log file:

Mysterious slot in Integrated Terminal UI

imgur
imgur

Items can(sometimes) be put in that slot, and sometimes shift clicked into it.

As seen with:
Forge: 14.23.5.2808
Terminals 1.0.1

Some Shenaningans

Sometimes, shift clicking items while in the terminal makes it go into the crafting grid on the crafting tab

Is the terminal meant to have this slowish lag to it? ergo, I pull an item out and a second later it is removed.
Is there something I can change to make it not?

predicate insertion does not reset scroll bar

Issue type:

🐛 Bug

Short description:

whenever you put a predicate in the terminal, the scroll bar isn't reset.

Steps to reproduce the problem:

make a system of a storage interface and terminal
fill the storage to an extent that the scroll bar becomes active
3.scroll to the bottom
4.insert a predicate that will narrow the inventory enough to deactivate the scroll bar
5.the scroll bar will be deactivated but still scrolled down, locking you with an empty screen until you remove the predicate.

Expected behavior:

the scroll bar should be reset to the top position whenever it is disabled (and possibly set back to original position once re-enabled)

Versions:

This mod: 1.0.1
Minecraft: 1.12
Forge: 14.23.5.2781

Log file:

Storage terminal crafting tab ignores toggle button.

If you have "Auto-refill crafting grid" disabled, it still refills the grid after you craft something, even though it is set to disabled.

Integrated Terminals: 1.0.6

itemized chicken problem

Issue type:

🐛 Bug

Short description:

the terminal seems to grab the wrong textures for certain items while scrambling them in the process, resulting in mismatches and outright missing textures

Steps to reproduce the problem:

take Chickens, Coop and Integrated Terminals
put a chicken item from Coop into a chest and look it up via a terminal

Expected behaviour:

Versions:

IT 1.0.3
forge 2808

Default storage terminal tab after world load

Issue type:

➕ Feature request

Short description:

Currently, if you have previously used the storage terminal in a session and re-open it, it remembers which tab you were viewing. However, on world load, it currently doesn't default to a tab - it would be nice if this could pick a tab to open on by default, should the tab be available.

items not going into the grid properly when holding shift in JEI

Issue type:

🐛 Bug

Short description:

when trying to put a recipe into the crafting grid using JEI while holding shift when pressing the button puts the wrong items in the wrong spots

this is what happens when trying to craft a chest (grid was empty before):

Steps to reproduce the problem:

try crafting any recipe when holding shift while pressing the + button in JEI

Expected behaviour:

it should act the same as if you were not holding shift

Versions:

This mod: 1.0.6
Minecraft: 1.12.1
Forge: 14.23.5.2831

Log file:

Crash when sorting by item count.

Issue type:

🐛 Bug

Short description:

When I boot up my game and enter my world I open up my crafting terminal and click sort by item count and it crashes.

Steps to reproduce the problem:

I just open my storage terminal and click the sort by item count button then it freezes for a bit then the game window completely closes.

Expected behaviour:

It used to sort by item count just fine? But now it crashes every time without fail.

Versions:

This mod: 1.0.1
Minecraft: 1.12.2
Forge: 14.23.5.2795

Log file:

https://pastebin.com/4u22exB7

Dupe stackable item

🐛 Bug

Dupe stackable item

How to do it?
https://media.giphy.com/media/kaNEErcd8RaStFJgmB/giphy.gif
Tested on:

Forge: 1.12.2-2838 - https://github.com/MinecraftForge/MinecraftForge/tree/1.12.x
Spongepowered 1.12.2-2838 API7 - https://github.com/SpongePowered/SpongeForge
Tablecloth 1.12.2-2838 - https://gitlab.com/bending/tablecloth/tablecloth

GUI height adjustment

Issue type:

➕ Feature request

Short description:

a button added to the left column that changes how many rows of inventory the GUIs can display (similar to refined storage)

Item in cursor switching by itself

Issue type:

🐛 Bug

Short description:

When taking an item stack out of the terminal while the terminal is set to sort on item amount, and dragging with the left or right mouse button, after letting go the items left in the cursor switch with another one.

Steps to reproduce the problem:

Set up as follows:

Inside chest:
Open terminal, select Item Storage tab and set Item Amount to Descending
Click on the Stone item stack, and click and drag it across the first two slots of your inventory
Item picked up should now be granite

Expected behaviour:

Item picked up should stay the same item.

Versions:

This mod: 1.12.2-1.0.6
Minecraft: 1.12.2
Forge: 14.23.5.2768

Log file:

Log File

Server hang when crafting stack through terminal

Issue type:

🐌 Performance issue

Short description:

Attempting to craft a stack of "Block of Crystalized menril" causes the server to hang for > 30 seconds.

Steps to reproduce the problem:

Setup:

A chest, a mechanical squeezer, mechanical drying basin, a drawer controller and ~50 drawers connected in a network (Terminal says ~8.5k items in storage).

Open terminal
Attempt to craft a block of crystalized menril from chunks. (This works just fine)
Attempt to craft a stack of blocks. (This makes server hang)

Versions:

This mod: 1.12.2-1.0.12
Minecraft: 1.12.2
Forge: 14.23.5.2844
All The Mods 3 Remix: 1.5.1

Profiler output:

Profiler while server was hanging (crafting 33 blocks, which was "fast" enough to not cause the server watchdog to trigger):

[10:16:04] [EntityProfiler/INFO] [TickProfiler]:
TPS: 13.894211
                    Single Entity | Time/Tick |     %
monster.EntityZombie -47,16,119:0 |     0.152 | 1.442
 PlantInteractorTile {37,65,26}:0 |     0.131 | 1.241
       item.EntityItem 52,26,81:0 |     0.089 | 0.838
monster.EntityZombie -31,62,-82:0 |     0.073 | 0.695
  passive.EntitySheep 121,69,31:0 |     0.067 | 0.630
   Chunk | Time/Tick |      %
 0: 7, 2 |     2.069 | 19.575
 0: 8, 2 |     0.557 |  5.269
 0: 2, 1 |     0.460 |  4.356
 0: 3, 0 |     0.325 |  3.077
0: 4, -2 |     0.266 |  2.521
  All Entities of Type | Time/Tick |      %
   passive.EntitySheep |     1.695 | 16.034
  monster.EntityZombie |     1.613 | 15.266
     entity.EntityFrog |     1.156 | 10.934
     passive.EntityCow |     1.141 | 10.797
monster.EntitySkeleton |     1.015 |  9.603
   Average Entity of Type | Time/tick | Calls
      PlantInteractorTile |     0.051 |  2502
     monster.EntityZombie |     0.051 | 26548
TileMechanicalDryingBasin |     0.050 |   834
       tile.TileContOreT1 |     0.044 |   834
   monster.EntitySkeleton |     0.042 | 19932

Sampler, from when attempting to craft a full stack:
serverhang.zip

Spark profiler, from when attempting to craft a full stack:
https://sparkprofiler.github.io/#wPmAbJSSzR

recipe sticks from crafting interface to player crafting

Issue type:

🐛 Bug

Short description:

whenever a valid recipe is made in the crafting tab of a terminal and viewed, the same item will appear in the player's 2x2 inventor recipe grid

Steps to reproduce the problem:

create a network with a storage interface and terminal
put in a recipe in the crafting tab [e.g. pickaxe]
close the terminal gui with the valid recipe awaiting completion in the 3x3
open the inventory, and the player's 2x2 output will show the output of the terminal [e.g. pickaxe]

attempting to take the item will cause it to dissapear

Expected behavior:

i expected that it wouldn't do that

Versions:

This mod: 1.0.1
Minecraft: 1.12
Forge: 14.23.5.2781

Log file:

server crash after restart when interacting with terminal

issue type: bug

when a server restarts integrated networks become corrupted, all integrated tunnels interfaces/importers/exporters cease to work, and integrated terminals will crash the server due to a ticking player. attached is the crash log for the server, networks become un-corrupted after all connectors of every integrated dynamics/addons are pulled up and placed down again
integrated dynamics version: 1.0.3
integrated terminals version: 1.0.1
integrated tunnels version: 1.6.2
crash-2019-02-20_19.37.22-server.txt
(i have no idea how to use github, sorry if i missed any info)

The storage terminal can destroy items dropped into the crafting output slot

Issue type:

🐛 Bug

Short description:

When the crafting grid is empty, dropping items on the output slot of the crafting terminal destroys them.

Steps to reproduce the problem:

Plug together a chest, a cable, an item interface and a storage terminal, so you can access the content of the chest through the terminal.
Put some items in the chest.
Using the terminal, select the crafting tab, and as the crafting grid is empty (no recipe), take some of the items from the network and drop them on the crafting output slot.

Expected behaviour:

We should be able to drop items into the output slot of the crafting tab. Moreover, they should never disappear.

Versions:

This mod: 1.12.2-1.0.9
Minecraft: 1.12.2
Forge: 14.23.5.2836
Integrated Dynamics : 1.12.2-1.0.18
Integrated Tunnels : 1.12.2-1.6.10
CyclopsCore: 1.12.2-1.5.0
CommonCapabilities : 1.12.2-2.4.4

I checked the bug with only these mods installed.

MouseTweaks/InvTweaks support

Issue type:

🐛 Bug

Short description:

Hello,
I found 2 issues with mousetweaks :
1st issue :
When you input multiple items in the terminal with mouse tweaks, aka holding shift and left click and moving the mouse over all the items in your inventory you, the first item/stack on wich you started shift clicking doesn't go in (you have to go over it a second time)

2nd issue :
the items inserted that way don't go in the storage, they directly go in the crafting tab

Here's a video that might help you understand what I mean by that :
https://streamable.com/c8ztm

Steps to reproduce the problem:

Hold Shift and Left click together starting on one of the item slot to insert items in the terminal
move your mouse over all the items you want to insert.
check the crafting tab.

Expected behaviour:

Items should go in the storage just like when you shift click one item slot at the time. :)

Versions:

This mod: IntegratedTerminals-1.12.2-1.0.1.jar
MouseTweaks-2.9-mc1.12.2.jar
Minecraft: 1.12.2
Forge: 2808

Log file:

Railcraft Creosote Bottles vs. Storage Terminal

Issue type:

🐛 Bug

Short description:

Railcraft Creosote Bottles are magically transformed into whatever fits into your fluid storage when shift-clicking them into the storage terminal's fluid tab. I tried this with a max-upgraded metal drum from "Barrels, Drums, Storage & More"
Also, if I click Creosote Oil fluid and then click an empty bottle, it takes 100 buckets of Creosote Oil out instead of 1.
Picking up an empty or filled bottle and clicking it into the terminal works as expected (i.e. transfers only 1)

I'd assume the same issue arises with Railcraft's other bottle, the Steam Bottle.

Steps to reproduce the problem:

Place a Metal Drum (might work with other storages, too)
Upgrade the Metal Drum using an Upgrade: Capacity x64
Place a Fluid Interface on the Metal Drum
Place a Logic Cable on the Fluid Interface
Place a Storage Terminal on the Logic Cable
Get a single Creosote Bottle
Open the Storage Terminal
Switch to the Fluid Storage tab
Shift-click the Creosote Bottle
- Expected: Metal Drum now contains 1 bucket of Creosote Oil
- Actual: Metal Drum now contains 128 buckets of Creosote Oil
If the Metal Drum isn't full, fill it to 128 buckets
Click the Creosote Oil
Click the Glass Bottle
- Expected: Metal Drum now contains 127 bucket of Creosote Oil
- Actual: Metal Drum now contains 28 buckets of Creosote Oil

Expected behaviour:

I expect Creosote Bottles to be worth exactly 1 bucket of Creosote Oil.
Not 100 and certainly not between 32768 and infinity :)

Versions:

This mod: 1.0.11
Minecraft: 1.12.2
Forge: 14.23.5.2836

Other related mods:

$ md5sum {Integrated,Barrels,railcraft}*.jar
c1aff93e2ddcedda892e338dd1cc0950 *IntegratedCrafting-1.12.2-1.0.8.jar
82b15eaa0c2b4421408db074ff464374 *IntegratedDynamics-1.12.2-1.1.0.jar
66f8eef05a5347180992a58adcc3e878 *IntegratedTerminals-1.12.2-1.0.11.jar
4dcb9b2079097ca6ae15cd723f071f94 *IntegratedTunnels-1.12.2-1.6.10.jar
948d49b065fd9f07cc046111d93b0700 *BarrelsDrumsStorageAndMore-0.0.24.jar
b6f0592e8f5c24d07fe065f1c97c8fda *railcraft-12.0.0.jar

Log file:

Crafting job terminal resetting scroll position

Issue type:

🐛 Bug

Short description:

When scrolling through a crafting plan in a crafting job terminal, the scroll bar gets reset to the top every second. In the GIF below, I am never manually scrolling up or re-expanding the sections.

Steps to reproduce the problem:

Queue a crafting job that has enough steps to be able to scroll in the crafting terminal
Scroll down in crafting terminal
Every second you will get reset to the top of the scroll area
If you collapse a section, it will automatically get expanded with the next refresh.

Expected behaviour:

Your scroll position should remain the same when the gui updates. It should only scroll back up if the crafting plan becomes shorter such that your current scroll height would be out of the new scroll area. Collapsed sections should also remain collapsed.

Versions:

Integrated Dynamics: 1.12.2-1.0.14
Integrated Crafting: 1.12.2-1.0.7
Integrated Terminals: 1.12.2-1.0.8
Integrated Tunnels: 1.12.2-1.6.9
Minecraft: 1.12.2
Forge: 14.23.5.2837

crash when looking up recipe

Issue type:

🐛 Bug

Short description:

when first starting up the game and joining a map, the terminal will start out with no tab selected, when then hovering over an item in the player inventory and pressing R to show its recipe the game crashes

Steps to reproduce the problem:

set up terminal
make sure the terminal has no tab selected in the top
hover over an item and press R

Expected behaviour:

the recipe shows

Versions:

This mod: 1.0.6
Minecraft: 1.12.2
Forge: 14.23.5.2831

Log file:

https://pastebin.com/N15MBbNH

Holding backspace in search boxes - incrementally delete

Issue type:

➕ Feature request

Short description:

When holding backspace in a search box in the terminal UI it would be convenient for the text to incrementally delete. Currently deletion requires repeatedly pressing backspace.

Removing the storage terminal with wrench causes the item in the crafting grid to drop

Issue type:

🐛 Bug

Short description:

When the storage terminal is removed with wrench, the item in the crafting grid will drop.
This will copy items.

Steps to reproduce the problem:

Get a chest with an item interface and a storage terminal.
Place any items to the crafting grid of the storage terminal.
Use wrench to remove the storage terminal, then the storage terminal itself and the item in the crafting grid will drop.
Put the removed storage terminal back into place, you will see the item in the crafting grid still there.

Expected behaviour:

Items in the crafting grid should not be dropped when the storage terminal is removed with wrench, because they are already stored in the NBT of the storage terminal.

Versions:

This mod: 1.0.6
Minecraft: 1.12.2
Forge: 14.23.5.2815

Log file:

Show crafting history

Issue type:

➕ Feature request

Short description:

Display the history of a synthetic article in the crafting job terminal
In the crafting job terminal, you can lock the quantity of a synthetic history record, and keep the locked items in the network no less than the set value

Server crash with un-configured Crafting Terminal

Issue type:

🐛 Bug

Short description:

When attempting to access the Crafting Terminal, it caused a server crash.

Steps to reproduce the problem:

Item Interface attached to Copper Colossal Chest Interface
Logic cable run 3-4 blocks out
Crafting Terminal attached to cable
Right click on CT brings up GUI, but crashes server

Note: This crash occurred twice on stream (can provide link, if desired), but was not reproduceable in single player

Expected behaviour:

Expected behavior was to open Crafting Terminal without issue. We know now that because there was no Storage Terminal attached to the system, it wouldn't have done anything, but we did not expect it to crash the server.

Versions:

This mod: 1.12.2-1.0.11
Minecraft: 1.12.2
Forge: 14.25.5.2838

Log file: https://paste.ee/p/2oLnd

Crash when accessing Storage terminal

Issue type:

🐛 Bug

Short description:

Game crashes occasionally when opening terminal

Steps to reproduce the problem:

I'm not able to recreate as it does not happen every time.

Expected behaviour:

____Terminal Open

Versions:

This mod: IntegratedTerminals-1.12.2-1.0.8
Minecraft: 1.12.2
Forge: 14.23.5.2836

Log file:

https://pastebin.com/DPDDuV7x

Crash on entering crafting job terminal

crash-2019-08-25_20.41.50-client.txt
Minecraft crashes after requesting a big recipe

In search box with JEI synchronize disabled text still updates

Issue type:

🐛 Bug

Short description:

When using a terminal with JEI synchronization disabled, the search box text updates if the JEI search box is updated

Steps to reproduce the problem:

Open a terminal
Ensure 'JEI synchronization' is disabled
Type into the JEI search box

Expected behaviour:

If JEI synchronization is disabled, the search box should not update

Versions:

This mod: 1.0.1
Minecraft: 1.12.2
Forge: 1.8.0

➕ Clear the crafting grid reverse (config)

Hey suggestion to add a config that reverse the button to clear the crafting grid. so when you normally click it goes in too storage and if you shift click it goes too the player

Add a machine to detect items in the terminal

Issue type:

➕ Feature request

Short description:

All kinds of things will be put in the box. When I check the storage terminals, although the items show the total number, they are not necessarily all in one box. This makes it impossible for me to simply know the total number of some of my projects to specify the production plan.

This machine can:

Detect the number of items in the storage terminal according to the variable card list
Output items to a channel or pipe based on the detected quantity

Enhancements to terminals

I was asked for my gripes with the terminals on discord and was told to post them on github so here we go

Terminals have a habit of forgetting your sorting settings. They'll reset sorting and JEI preferences and that's really annoying. Also mentioned in #28
Putting items into the terminal is funny. It doesn't behave like a normal inventory, so you can't insert swaths of items using mouse tweaks or inventory tweaks features. You're left to insert them one stack at a time. If you try, one stack might go into the system, but the rest will either go into the crafting grid (even if you're on the storage tab) or act like there isn't an inventory at all. Maybe behind the scenes the terminal could have a small internal buffer of its own that you put items into, then it distributes said items to the appropriate locations. Said buffer would also be visible by the system so you still have access while they're in flux. Just a thought.
Shift-clicking items out of the terminal moves ALL of the items into your inventory. So if I have like fifty stacks of cobble and only need the one stack, I can't just shift click it into my inventory or my pockets will fill entirely with cobble. When I'm shift clicking items out of a terminal, I almost always just want the one stack not all the stacks.
The crafting grid clear button behavior should be reversed. Or at least there should be a button to reverse it. I very VERY rarely actually want the grid to empty into my inventory. For the main system, I would prefer the excess items just go into the system instead. It's mainly useful for items to pop into your inventory instead when you're using a terminal as a debug tool, like I did for my salt producer. Furthermore, when you have stuff in the crafting grid and you load up a new recipe, all of the items that were in the grid go into your inventory instead of the system.
[ ] When you right-click the search bar, it selects the text instead of just clearing it like you'd expect. Though this is probably an issue with integrated dynamics as a whole since I've had that happen with the logic programmer too. It's pretty much universal at this point that in minecraft, if you right-click a search bar, it clears it. Just selecting it seems like a weird half-step to that that serves no apparent purpose.
JEI only recognizes the system's inventory for auto-filling recipes. It does not recognize items in your own inventory.

Persist storage terminal settings across sessions

Issue type:

➕ Feature request

Short description:

It would be nice if previous storage terminal settings (tab selected, JEI sync mode, sort mode etc) could be persisted - saving the settings on exit and loading again when loading the world back.

Client Crash When Viewing Crafting Terminal When Subjob Completes

Issue type:

🐛 Bug

Short description:

When viewing the progression of a complicated crafting job in the Crafting Terminal, the client sometimes crashes when one of the subjobs completes.

Steps to reproduce the problem:

I'm not sure if the issue is 100% reproducible, but I know that it did happen when crafting Actually Additions Phantomfaces from scratch (crash happened when the subjob for Diamatine Crystals finished).

Set up a network that autocrafts an item that requires additional components to be crafted.
Request an autocraft for the item (it may be possible that the bug only appears when more than one of the item is requested).
View a Crafting Terminal on the network while the craft is in progress, and view the details for that specific crafting job.
The crash may occur when one of the subjobs for the crafting job completes.

Expected behaviour:

The client shouldn't crash when a subjob completes.

Versions:

This mod: 1.12.2-1.0.10, also Integrated Crafting is 1.12.2.-1.0.8, Integrated Tunnels is 1.12-1.6.10, Integrated Dynamics is 1.12.2-1.1.0
Minecraft: 1.12.2
Forge: 14.23.5.2838

Log file:

https://pastebin.com/zyDMS42y

Terminal interaction does not sync instantly

Issue type:

🐛 Bug

Short description:

Even though I implemented this before, storage updates are not being updated instantly after interaction with the terminal.

job terminal resource mode

Issue type:

➕ Feature request

Short description:

a mode for the crafting job terminal that can give an exact count of what's missing and what's available for an uncraftable task in a straight list instead of a tree

Dupe using Actually Additions Player Interface and Storage Terminal

Issue type:

🐛 Bug

Short description:

Using an Actually Additions Player Interface and a Storage Terminal, you can dupe any stackable item as long as you have more than half a stack of it.

Steps to reproduce the problem:

Place an AA Player Interface
Place an ID Item Interface on the AA Player Interface
Place a Logic Cable on the Item Interface
Place a Storage Terminal on the Logic Cable
Get 33 blocks of dirt
Open the Storage Terminal
Switch to the Item Storage tab
Click the dirt in the Storage Terminal
Click the dirt in your inventory
- Expected: Your inventory contains 33 dirt
- Actual: Your inventory contains 64 dirt

Expected behaviour:

No dupe :)

Versions:

This mod: 1.0.12
Minecraft: 1.12.2
Forge: 14.23.5.2847

Other related mods:

$ md5sum {Integrated,Act}*.jar
c1aff93e2ddcedda892e338dd1cc0950 *IntegratedCrafting-1.12.2-1.0.8.jar
82b15eaa0c2b4421408db074ff464374 *IntegratedDynamics-1.12.2-1.1.0.jar
fa9588c185bb9de5a725c1486ed3f57d *IntegratedTerminals-1.12.2-1.0.12.jar
4dcb9b2079097ca6ae15cd723f071f94 *IntegratedTunnels-1.12.2-1.6.10.jar
5b619cf05cc827426f80df4b716092f5 *ActuallyAdditions-1.12.2-r150.jar

Log file:

Possible to click items into gap between itemslots, canceling extraction.

If you go to extract items from a terminal with your mouse cursor, you can end up clicking between slots in your player inventory, returning the items to the system.
https://i.imgur.com/eLM2dkR.png

Expected behaviour is no gap when mouse-overing slots.
https://i.imgur.com/x8CYl7K.png

Integrated Terminals: 1.0.1

Multiple Storage Channels causes craftable's to not show in terminal under "all"

Steps to reproduce:
Make a small network, with 2 Item Interfaces, set one of them to Interface Channel 1.
put oak logs in the channel 0 interface attached storage.
put something else in the channel 1 attached storage.

place a crafting interface, put a recipe for oak planks in it.
Place a storage terminal.
You will not be able to see the craftable recipe when the terminal is in "All" mode, switching to channel 0 will cause it to appear.

https://imgur.com/z6iwa8M :All
https://imgur.com/IkenWs8 :Channel 0
https://imgur.com/ppiqsTm :Channel 1

Forge: 14.23.5.2837
Integrated Terminals: 1.0.8
Dynamics: 1.0.14
Tunnels: 1.6.9
Crafting: 1.0.7

Auto-fill crafting grid with full stack and send back items to the network directly when calling a new recipe

Issue type:

➕ Feature request

Short description:

Auto-fill crafting grid will full stack of items if those items already exist in the system, and only refill the items if there is none of them instead of refilling them every time.
It allows a faster crafting process as it requests lesser requests from the system, as the crafting is a bit slow when crafting a large amount due to the need of pulling necessary items every time an item is crafted. If possible, caching the recipe like what FastWorkbench did can help as well.
Some mods like Simple Storage Network and Crafting Station from Tinkers Construct are able to mimic the vanilla crafting table, and thus able to use what FastWorkbench provides to speed up the crafting speed. Maybe they can be a good reference.
Send back items to the network on default when calling a new recipe from JEI.
I found that most of the time items are pulled from the network instead of player inventory, so it would make more sense that those items should be back to the network on default. It will be great if it is configurable by either mob config or GUI.
Related to #39

Thanks for the great mod. Finally, I can get rid of the bits based storage system like AE and RS.

Crash on entering controls menu

Issue type:

🐛 Bug

Short description:

When opening the controls menu, Minecraft crashes with a NullPointerException. Removing Integrated Terminals fixes this issue.

Steps to reproduce the problem:

Start up Minecraft.
Options -> Controls
Minecraft should crash.

Expected behaviour:

Expected to open up the controls menu to change my auto-jump setting.

Versions:

This mod: 1.0.0
Minecraft: 1.12.2
Forge: 14.23.5.2807

Log file:

https://pastebin.com/reP6201Y

unable to auto complete certain recipes from jei even though the items are in the system

Issue type:

auto complete certain recipes from jei

Short description:

unable to pull certain recipes from jei even though the items are in the system

Steps to reproduce the problem:

i will give 1 item as an example, the world block exporter

get a container with an item interface and a storage terminal
place an item exporter, a logic director and a diamond pick in your system
open your storage terminal and click the world block exporter from jei and then click the +sign to pull the recipe in your monitors crafting grid (it does not recognize the pick)

Expected behaviour:

it should auto complete the recipe because you have a diamond pick in your system

Versions:

IntegratedTerminals-1.12.2-1.0.6
Minecraft 1.12.2
Forge 14.23.5.2781

portable terminals

Issue type:

➕ Feature request

Short description:

portable terminals. a short ranged one can be made with a terminal and a mono-directional connector and a long/multidimensional one with a omni-directional connector. they could be linked to a network via another omni/mono-directional connector on the network itself.

crafting recipes don't respect predicates

Issue type:

🐛 Bug
(interaction with integrated crafting)

Short description:

when you put a predicate filter in the slot, all crafting recipes will be shown, regardless of if they are valid via the predicate

Steps to reproduce the problem:

make a system of a storage interface, terminal, and valid machine with crafting recipes [e.g. crafting table]
make a predicate [e.g. is damageable]
when the predicate is inserted into terminal, all recipes will show.

Expected behaviour:

recipes should respect the predicate inserted

Versions:

This mod: 1.0.1
Minecraft: 1.12
Forge: 14.23.5.2781

Log file:

Issue with GregTech CE

Issue type:

🐛 Bug

Short description:

Most Blocks from the GregTech Community Edition are invisible when viewed from the terminal.

Steps to reproduce the problem:

place down chest
put blocks from GregTech CE inside the chest
connect a terminal to the chest
open the terminal

Expected behaviour:

all blocks are shown

Versions:

This mod: 1.0.10
Minecraft: 1.12.2
Forge: 14.23.5.2847
GregTech CE: 1.8.8.440

[1.12.2] Dependancy vers Error

I.Terminals & Tunnels sais it requires Intergrated Dynamics vers 1.0.9 or higher, but as yet no such version exists, is this an Error or ?

better item extracting

Issue type:

➕ Feature request

Short description:

1: pressing the mouse wheel multiple times should take more of that item out of the storage, instead of just putting it in and out
2: scrolling the mouse wheel should allow you to select a specific amount to take (scroll down should "select" more of that item to transfer and scroll up should "unselect" more of said item)
3:shift+middle click should take 1 of the selected item directly into/out of the selected inventory each time.

Color not being reset in crafting job terminal after fluid rendering

Issue type:

🐛 Bug

broken textures

Issue type: Broken Textures with Pam's Harvest Craft

🐛 Bug

Short description:

Added a peanut butter sandwich as a craft recipe, looked at the storage terminal to craft said sandwhich and see a broken texture.

Steps to reproduce the problem:

add pam's recipe as a crafting item
open storage terminal
view craft able items

Expected behaviour:

should see texture of item

Versions:

This mod: 1.12.2-1.04
Minecraft: 1.12.2
Forge: 14.23.5.2810