Giter Site home page Giter Site logo

Comments (3)

Cytraen avatar Cytraen commented on August 19, 2024

Is there something wrong with giving an empty list manually? The OpenAPI spec doesn't say whether a query param is required or not, and I would prefer to not add a special case for individual endpoints.

The API documentation states You must request at least one component to receive results anyway so I don't see a reason to change this.

from bungiesharper.

PatrickMatthiesen avatar PatrickMatthiesen commented on August 19, 2024

I’m kinda new to using open source libraries, but I just didn’t see it in the code documentation (might just have missed it), but bungie does say it in their doc. So was mostly for convenience when using your library.

from bungiesharper.

Cytraen avatar Cytraen commented on August 19, 2024

The documentation in BungieSharper is a direct copy-paste of the Bungie documentation. The bit I quoted is under the documentation for the components parameter.

from bungiesharper.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.