cytraen/bungiesharper

A .NET client library for the Bungie.net API.

bungiesharper's Issues

Destiny2_GetProfile needs to send an empty list if no components are given

the server returns 500 if the components part is not in the URL in the header

Does this not work with Blazor clientside wasm?

When I try to inject the BungieApiClient it just gives me a console error about how the Operation is not supported on this platform. Is this not available on client side blazor? I had it working great on my blazor server application but for ease of deployment I ended up switching it. Is there something more I need to be doing?

Proper initialization

Currently considering

• Internal IsInitialized bool, which will prevent any significant changes once set
• Move solely to BungieClientConfig and remove other constructors altogether
• Go back to / re-add {client}.SetX() methods

In any case, BungieClientConfig (available in cef8d4d onwards) is not going anywhere

GetOAuthAuthorizationUrl(state) not working properly

for some reasons, GetOAuthAuthorizationUrl doesn't put the status nor the client id in the oauth link

Manifest data not populating AggregateDestinyDefinitions

Using the following block of code, definitionList does not contain any data. The object is created but with a collection of null properties.

var manafest = client.Api.Destiny2_GetDestinyManifest().Result;
var definitionListJson = new WebClient().DownloadString($"https://www.bungie.net/{manafest.JsonWorldContentPaths["en"]}");
var definitionList = JsonConvert.DeserializeObject<AggregateDestinyDefinitions>(definitionListJson);

Destiny2_GetDestinyEntityDefinition returns only base type

Destiny2_GetDestinyEntityDefinition request returns only DestinyDefinition base type, but I need specific type (e.g. DestinyActivityDefinition), that inherited from DestinyDefinition type.

membershipId gets rounded up

the membership id's gets rounded up, it looks to be a problem in JSON's number conversion method, so it might be a better idea to keep the id's as strings.

https://stackoverflow.com/questions/62108538/why-long-types-are-rounded-in-net-web-api-json-response-payload-after-16-digits

I get the problem in Destiny2_GetLinkedProfiles (if you wanted a place to test for yourself)