d-tux/go-fstab

Simple fstab parser for Go

go-fstab's Issues

Unable to get disk information of ubuntu18.04

ubuntu18.04的磁盘信息并没有保存在/etc/fstab
文件

Constants are all 0

You missed iota in the const list.

Also, it would be better to make them typed constants.

diff --git i/mount.go w/mount.go
index b45513f..e7b6a1a 100644
--- i/mount.go
+++ w/mount.go
@@ -28,16 +28,16 @@ type Mount struct {
        PassNo int
 }

+type DeviceIdentifierType int
+
 const (
-       Path = 0
-       Label
-       UUID
-       PartUUID
-       PartLabel
+       Path      DeviceIdentifierType = iota
+       Label     DeviceIdentifierType = iota
+       UUID      DeviceIdentifierType = iota
+       PartUUID  DeviceIdentifierType = iota
+       PartLabel DeviceIdentifierType = iota
 )

-type DeviceIdentifierType int
-
 // parseOptions parses the options field into an array of strings
 func parseOptions(optionsString string) (options map[string]string) {
        options = make(map[string]string)

Unrecognized printf verb

go vet says:

mount.go:185: unrecognized printf verb 'i'

does this library works for windows too ??

does this library works for windows too ??

Sprintf should not be public

The name is misleading and leads you to think that it behaves like fmt.Sprintf, which is not the case.
go vetactually complains about that.

In order to use it properly, you need to known what arguments are actually passed in what order to fmt.Sprintf, which you don't unless you read the source; that makes it unsafe to use.

Also, i can't think of any public use case for this.
Let's make it private.