Comments (7)
kavandalal
commented on August 19, 2024
1
I will create PR shortly, but just to remove error from the description, under "Acceptance Criteria" you have written to update CheckboxInput.stories.tsx .
from ui-kit.
kavandalal
commented on August 19, 2024
1
@nataliepina PR created, Thanks for giving the link to other refactor commit 👍
from ui-kit.
kavandalal
commented on August 19, 2024
Hi @nataliepina , I tried refactoring the code. I was successfully able to get the RadioInput component's code visible.
This should be the ideal output right ?
from ui-kit.
nataliepina
commented on August 19, 2024
@kavandalal yes, that's exactly what we're looking for thank you! I can assign this to you and feel free to create a PR when you're ready.
from ui-kit.
kavandalal
commented on August 19, 2024
@nataliepina I should follow this approach. right ?
from ui-kit.
nataliepina
commented on August 19, 2024
@nataliepina I should follow this approach. right ?
Yes that's correct. Please let us know if you have any questions. Thank you for contributing to UI Kit ⭐
from ui-kit.
nataliepina
commented on August 19, 2024
I will create PR shortly, but just to remove error from the description, under "Acceptance Criteria" you have written to update
CheckboxInput.stories.tsx.
Thank you, i've corrected that now. We have another issue to correct the CheckboxInput in a similar way.
from ui-kit.
Related Issues (20)
- Storybook Component Documentation Update - Refactor the SegmentedControl component story HOT 2
- Storybook Component Documentation Update - Refactor the ToggleBoxInputList component story HOT 2
- Storybook Component Documentation Update - Refactor the Dropdownable component story HOT 1
- Storybook Component Documentation Update - Refactor the Modal component stories HOT 3
- Refactor FormFieldWrapper components HOT 5
- Dependency Update - fork-ts-checker-webpack-plugin version 9 HOT 2
- Fix extra characters added by style dictionary
- CSS fix for table column re-sizer HOT 7
- Update the `@testing-library/react` dependency HOT 13
- Update `babel-loader` to the latest version HOT 4
- Update `downshift` to the latest version HOT 2
- Update `wait-on` dependency to the latest version HOT 1
- Update `fork-ts-checker-webpack-plugin` to the latest version HOT 2
- Update the `svgo` dependency HOT 9
- Update 'svgo' dependency to the latest version
- Update the `downshift` library to the latest version HOT 2
- Update @testing-library/jest-dom to version 6 HOT 1
- Storybook Component Documentation Update - Refactor the CheckboxInput component story HOT 3
- Update `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` to the latest version. HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ui-kit.