Comments (14)
@nataliepina i am still working on it, trying to understand issues and making new pull request
from ui-kit.
hey @nataliepina i would like to take up this issue, can you please guide how to start with this issue it would be a great help
from ui-kit.
Hi @nikhilgarg26 thank you for your interest.
To start this issue i'd recommend reading over the contribution guide and getting UI Kit set up and running locally.
Next you can run npm install @typescript-eslint/parser@latest
and npm install @typescript-eslint/eslint-plugin@latest
to update those dependencies.
After that, run some tests by running npm run lint
and npm run test:types
.
There may be some type errors it will trigger after that and you can work on reading over the errors and fixing them all.
There shouldn't be too many errors triggered, maybe around 6 the last I checked.
Let us know if you have any other questions. I'll assign it over to you now.
from ui-kit.
Thanks @nataliepina for assigning this issue, i will give an update as soon as possible.
from ui-kit.
@nataliepina resolved some of the issues but still getting error: Insert โยทยทยท
i guess the elslint and prettier configs are conflicting can you please help on this
from ui-kit.
got it just some --fix
i need to run
from ui-kit.
getting this error while doing git commit -m "update @typescript/eslint dev-dependency"
please help
from ui-kit.
Part of this work will be to resolve those eslint issues. If you're unable to, i'd suggest to get everything into a pull request and we can take a better look to help resolve the issues. It will be helpful to see the full error messages and have some additional details from your findings with this work.
As far as the commitlint command not found error. Be sure to read over the Contributing documentation carefully. For example, we follow conventional commits. in your example you are missing the commit type. In your case you'd want to use: git commit -m "chore: update @typescript/eslint dev-dependency".
If you update any of the code to fix the eslint errors you'd want that in a separate follow up commit that may be a refactor or fix commit depending on what you've done, git commit -m "fix: resolved eslint issues"
Try that and make sure you've set everything up outlined in the contributing documentation, let us know if you're still having issues after that.
from ui-kit.
I noticed you closed your pull request @nikhilgarg26 are you still working on this?
I believe the way to fix the commitlint error you encountered can be to run npm install -g @commitlint/{config-conventional,cli}
. Try that out and let us know if you need further guidance if you'd like to create another pull-request.
from ui-kit.
@nikhilgarg26 are you still working on this one? Anything we can help with?
from ui-kit.
@electron97 I believe @nikhilgarg26 was working on this. Although he hasn't responded. Can you please be sure to request for an issue to be assigned to you before created a pull request for it? This aligns with our community guidelines. Thanks.
from ui-kit.
@electron97 I believe @nikhilgarg26 was working on this. Although he hasn't responded. Can you please be sure to request for an issue to be assigned to you before created a pull request for it? This aligns with our community guidelines. Thanks.
@nataliepina sure will follow this from next time onwards. Could you please assign this issue to me if the other assignee hasn't responded yet? Thanks
from ui-kit.
Sorry, just saw that this project uses requests for PR's I'll close mine.
from ui-kit.
No problem @jaas666, thanks, i'll add some more issues to this project soon if you'd still like to contribute on another issue.
from ui-kit.
Related Issues (20)
- Storybook Component Documentation Update - Refactor the RadioInput component story HOT 7
- Storybook Component Documentation Update - Refactor the SegmentedControl component story HOT 2
- Storybook Component Documentation Update - Refactor the ToggleBoxInputList component story HOT 2
- Storybook Component Documentation Update - Refactor the Dropdownable component story HOT 1
- Storybook Component Documentation Update - Refactor the Modal component stories HOT 3
- Refactor FormFieldWrapper components HOT 5
- Dependency Update - fork-ts-checker-webpack-plugin version 9 HOT 2
- Fix extra characters added by style dictionary
- CSS fix for table column re-sizer HOT 7
- Update the `@testing-library/react` dependency HOT 13
- Update `babel-loader` to the latest version HOT 4
- Update `downshift` to the latest version HOT 2
- Update `wait-on` dependency to the latest version HOT 1
- Update `fork-ts-checker-webpack-plugin` to the latest version HOT 2
- Update the `svgo` dependency HOT 9
- Update 'svgo' dependency to the latest version
- Update the `downshift` library to the latest version HOT 2
- Update @testing-library/jest-dom to version 6 HOT 1
- Storybook Component Documentation Update - Refactor the CheckboxInput component story HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ui-kit.