Comments (3)
The problem with named parameters is that it’s kind of a pain to implement the raw projections that way. Also, since we already released the raw projections in d3-geo 1.1 and d3 4.1, it’d have to wait until D3 5.0 anyway. So, I think I’m going to close this. Unlike d3-ease and d3-interpolate I don’t intend the raw projections to be used unless you are defining a custom projection, which should be quite rare (as compared to configuring an existing projection).
from d3-geo-projection.
There’s a big reason not to define the raw projections as a property of the (non-raw) projection which is that it makes it impossible to import just the raw projection definition: you end up pulling the whole projection pipeline in, including clipping and resampling, which is comparatively huge. Of course in the vast majority of cases this wouldn’t actually matter since you are probably going to need that any if you are working with projections… but still, it’s cleaner if it’s a separate symbol.
As for discoverability, the main thought that comes to mind is using named parameters as we do for d3-ease and d3-interpolate. For example, instead of this:
var bonne = d3.geoBonneRaw(Math.PI / 3);
You’d say this:
var bonne = d3.geoBonneRaw.parallel(Math.PI / 3);
It makes the parameters more discoverable, forces all parameters to have defaults, and eliminates the distinction between parameterizable projections and non-parameterizable projections. Of course it’s still a bit awkward to have the inconsistency between radians and degrees… and the necessary duplicate API in the non-raw projections where some parameters have side-effects like setting a rotation.
from d3-geo-projection.
+1 for named parameters; also there seems to be some need for a generic function that would help change a parameter (like parallel1).
from d3-geo-projection.
Related Issues (20)
- Snyder's "Magnifying-Glass" projections?
- Relax d3-array dependency to 1-2. HOT 3
- compatibility of geoRectangularPolyconicRaw with geoInterrupt HOT 3
- There are es2015 in the final package file HOT 3
- Count Number Of Visible Objects Within Projection HOT 1
- What is the source of the projections? HOT 10
- Pangean projection HOT 5
- Two-point equidistant projection has artifacts when showing the whole world HOT 6
- geoPath.curve ? HOT 1
- Support All US Territories in Albers USA projection HOT 7
- geoProject converts hole to MultiPolygon HOT 2
- Using this lib in TypeScript? HOT 2
- interrupted projections sometimes have partially undefined inverse HOT 2
- More customizable Wagner projections (and others)? HOT 7
- Add Cupola projection HOT 14
- A new quincuncial projection HOT 10
- geoStitch mislabels the union of two Polygons forming a hole on the date line as a MultiPolygon
- Could not find a declaration file HOT 2
- ISEA visualization? HOT 3
- No types definition package of d3-geo-projection HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3-geo-projection.