daf98/portfolio

This is my personal portfolio with all of my projects, my info and ways to contact me.

portfolio's Issues

[FIX] Indentation

Indentation

• Some of the code is not nested inside the body element of the html file, this is not critical because the code works but it might make it easier to read.

Optional Suggestion

• Use '@media (min-width: 1440px)' instead of '@media only screen and (min-width: 1440px)', it does the same but I believe it'd make a little easier to write because you're using less code to do the same.
• Please use relative links for images in CSS to avoid broken paths
• Kindly use more IDs instead of classes for unique elements

Thank you for your presentation!

Suggestions of improvement in code

Hi Daf 👋 ,

Good job so far! 🎉 🎉 🎉
There are some optional suggestions that you may change to improve your code.

• In the index.js file Instead of using .remove you can use .toggle (It removes the class if it already exists, otherwise, it adds it to the collection).
• Kindly put your images out from the "CSS" folder in another folder that can be called "Images" to make your code well-organized.
• You might divide your styles.css file for each section (e.g. header.css, aboutme.css) to make your code more readable.

Bus fixed on bug brancch

Need to fix bugs on the index.js file

• Add an extra "e" to mouseenter event. See here
• Remove dot '.' from const email and error since they are accessed with getElementById. See here
• Change user.namevalue to user.nameValue to properly access to the const See here

Good Job So Far

Everyone agreed that the pull request's code uploaded was great and it deserved to be approved,
Good job! 😃 😃