daishisystems/daishi.amqp

Microservices SDK for .NET applications

daishi.amqp's Issues

Multiple clients re-use the same return queues

Context: the AMQP project, the QueuePool.cs file

Since each MicroService client keeps track of which return queues (GUID named) are used in its own ConcurrentBag, it is inevitable that other clients will also enumerate all GUID named queues and also see them as unused return queues - but blissfully unaware that another client might have started to use a queue.

I suggest that each client has its own pool of return queues - maybe by prefixing each GUID named queue with the client's unique name? In my scenario this should work because I will only have around 10-20 clients (other microservices), each with a unique name - but I'd like to hear other suggestions?

Hardcoding of username and password

In the AMQP's QueuePool.cs there is a hardcoded username and password:
Line 30: var manager = new RabbitMQQueueMetricsManager(false, "localhost", 15672, "paul", "password");

Can we rather read these values from a .config file (e.g. appSettings) ?
Specifically the Servername, Port, Username and Password parameters.

Old messages left in return queue

When a client send a message to a microservice, the client needs to identity a queue to be used for the return message.
The clients gets a "unused" queue from QueuePool.Instance.Get();
But the fact that it is unused is determined by the client keeping track of which return queues are used.
If the previous user of the queue never fetched its message from this queue, the queue might still have a message in it.

I solved this problem by purging the queue everytime I get an "unused" queue from QueuePool.Instance.Get() by doing a channel.QueuePurge(queue.Name)

Change Request

Since the assumption is that when a client gets a new return queue from QueuePool.Instance.Get(), that it would be "ready for use", and empty, would it be possible to make this a default behavior (first purging any potential messages from it) inside QueuePool.Instance.Get() before returning the queue to the client?

adapter.connect errors when using RabbitMQ 4.1.1

After upgrading to 4.1.1 I get the following error. If I downgrade it all works fine again. If you need any more info please don't hesitate

ERROR - Error creating the service bus System.MissingFieldException: Field not found: 'RabbitMQ.Client.ConnectionFactory.HostName'.
at Daishi.AMQP.RabbitMQAdapter.Connect()
<snip....>

       _adapter = RabbitMQAdapter.Instance;
        _adapter.Init("localhost", 5672, "guest", "guest", 50);

        _rabbitMqConsumerCatchAll = new RabbitMQConsumerCatchAll(GlobalResources.Properties.Resources.SurveyorMessageQueueText, 10);
        _rabbitMqConsumerCatchAll.MessageReceived += OnMessageReceived;

        _adapter.Connect();  
        _adapter.ConsumeAsync(_rabbitMqConsumerCatchAll);