damien-carcel/userbundle

DEPRECATED - A ready to use Symfony 3+ UserBundle

userbundle's Issues

Use Symfony Guard authentication system

Q	A
Bug report?	no
Feature request?	yes
BC Break report?	no
RFC?	no
UserBundle version	1.0

• Should this be done in the bundle directly, or only in a Symfony application?
• If in the bundle, this could imply adding API controllers.

Remove the FOS UserBundle

Q	A
Bug report?	no
Feature request?	yes
BC Break report?	no
RFC?	no
UserBundle version	1.0

Each of the following main points will be done in a dedicated pull request.

• Remove entirely the dependency to FOSUserBundle
  • move the code in the bundle as a first step (should it just be completely rewritten following Symfony documentation?)
  • remove UI related code and dependencies, keep only needed Symfony components
  • Doctrine mapping should remain unchanged (no need for DB migration)
  • KhatovarWeb application should still be able to work with this code
• Add akeneo/php-coupling-detector to enforce respect of layers and use it on Travis CI
• Reorganize the code with a clear separation between domain, application and infrastructure
  • at this point, there should be adapters only for database (remove useless code from FOS User bundle that could remain, if not already done)
  • service declaration are framework related and so should be in the infrastructure layer
  • acceptance tests added in #4 should still work
• Add console commands to manage the bundle
  • this will be, with the database, the only adapters implemented directly in the bundle, others (like UI/API) may be in a final Symfony application only
  • add system tests for these commands

Test the bundle correctly

This is a needed step before rewriting the bundle following a true DDD pattern (if it is ever done).

• Write acceptance tests
  • they need to cover all the use cases of the bundle (including what is directly done by the FOS User bundle)
  • this means the bundle must have clear entry points (services) for these use cases, only those services should be used in controllers => very likely to be repositories
  • storage must be replaced with an in-memory variant
• Add needed integration tests
• Add possibly missing unit tests
• Define the system tests by tagging some of the acceptance tests
  • commands => these tests will be executed directly in the bundle
  • controllers => these tests will be executed in the applications using the bundle

Add group functionnality

Sending an email to the application super admin when a new account is created

Add Integration and acceptance tests configuration

Q	A
Bug report?	no
Feature request?	yes
BC Break report?	no
RFC?	no
UserBundle version	1.0

Don't add the tests themselves, only what is needed to run them.

• Update the dependencies to remove the framework-bundle, keep only needed components, and Symfony v4
• Organize the tests
  • phpspec is used for unit tests
  • behat is used for acceptance and integration tests

Look at https://github.com/damien-carcel/app-skeleton/tree/symfony-api for tests organization.

Deprecate this bundle

No new version will be done after 0.3. This bundle is to be reintegrated in Khatovar Web (see damien-carcel/khatovar-web#78).

All the developments that were planned for next versions will be done by creating a new user management in the app skeletons (see damien-carcel/app-skeleton#18).