damyanbogoev/flask-bookshelf

Flask Series

flask-bookshelf's Issues

[Question] Where to see how is the proper way using lang_code in URLs ?

I have some example

https://stackoverflow.com/questions/49496761/two-language-flask-site-with-or-without-blueprints/49948870#49948870

but I am not sure if I correctly using some details, I need to have app without babel and international urls with lang_codes and logic for switching language and saving lang_code in cookie with blueprint or without it

Not an issue, a request.

Thank you for the tutorial. It was immensely helpful. I would love to see a section on setting up Celery for background tasks.

waiting for the later series, hah, thanks

will close this later

Handling exception from Babel when no local found in url - babel.core.UnknownLocaleError

I didn't entirely follow the tutorial but did find the Localisation part very helpful, hence I implemented the solution in my own app.

One issue I encountered with this implementation is that if I had a url like this "www.example.com/path-that-does-not-exit/" then instead of seeing a 404, I got a babel error.

The error was due to the fact that the localeselector in babel got the 'path-that-does-not-exit' as locale. To fix this, I did the following here,

flask-bookshelf/bookshelf/__init__.py

Lines 44 to 48 in c1549bc

	@babel.localeselector
	def get_locale():
	return g.get('lang_code', app.config['BABEL_DEFAULT_LOCALE'])

    def get_locale():
        if g.get('lang_code') not in app.config['SUPPORTED_LANGUAGES'].keys():
            return app.config['BABEL_DEFAULT_LOCALE']
        else:
            return g.get('lang_code', app.config['BABEL_DEFAULT_LOCALE'])```