dangerdak/chrappjs

Chr(istmas) App: A secret santa app

chrappjs's Issues

move validate module

Should be in 'lib' rather than 'controllers'

Error messages

display message to user if there's been an error/invalid input

Logout

Users should be able to logout

• button only shows when logged in
• deletes token from local storage

Production and development environments

Set NODE_ENV environment variable to check which environment is running

e.g see this issue:
dangerdak/interstellar-soulmates#40

Passwords should be salted

In https://github.com/dangerdak/chrappjs/blob/master/src/controllers/passwordModule.js passwords should be salted (use bcrypt) rather than just hashed using crypto

Authenticated tests

for e.g. /groups page

https://jaketrent.com/post/authenticated-supertest-tests/

https://medium.com/@juha.a.hytonen/testing-authenticated-requests-with-supertest-325ccf47c2bb

Database seed file

Should be able to reset database but also add in initial data for testing purposes

Create database build files

• db_build.js
• db_build.sql
• db_connection.js

homepage

The app should have a home page - this could be the groups page, or a user dashboard with groups and wishlists or something...

Use react

Use react for the front end to get practice :)
pages to convert:

• login
• Register
• View groups
• authentication (using jwts, frontend)
• create a group
• test private routes

Group detail

add group detail component showing

• name, description, budget
• members

Tests hang

Figure out how/where to close db connections

waterfall in tests?? promises?

https://node-postgres.com/features/pooling

https://github.com/brianc/node-pg-pool#shut-it-down

Group invitations

Add ability to invite people to a group, and to email and accept invitations

• Add form with inputs for peoples emails #52
• Email invites to people
• Create table for invites? (from_id, to_email, group_id)? redis?
• show list of invited people (and indicate if they've accepted yet)
• Each group needs an admin (groups now have an owner)

Html head

partials/htmlHead.hbs

• should contain required settings for accessibility
• responsiveness

Create groups

• Add groups table to db
• Add page for creating a new group
• Write insertGroup query which saves a new group to db
• Write validator for group info
• Write getGroups query which returns groups for a user id
• Show groups a user belongs to

Validate user input client side

on all form pages:

• login
• register
• create group

Restrict '/groups' page

Only show page if logged in

• express-session vs cookie-session
• create 'users' table in db

Invites - functionality

• User submits invites form
• Emails are validated client side
• Emails are validated server side
• Invitation token created for each invite - corresponding to group id and email
• Emails sent
• User follows link containing invitation token
• Acess invites db table & users table, check if email is registered already
• If existing user, asked to log in (if not already)
• If new user, asked to register
• On reg/login, user is added to the group
• Invitation token deleted from db

Create users

• create database
• create users table
• password hashing and validation
• create session on login/register

Validate user input server side

Backend validation

• include tests
• using a validation module

Serve templates

Site should be able to serve some pages.
Start with:

• /register
• /login
• /groups

Create db build files

db_connection.js, db_build.js and db_build.sql

Forgotten password

Users should be able to request to change their password if they've forgotten it

Proptype issue on login page

Warning: Failed prop type: The prop location.state is marked as required in Login, but its value is undefined.

When logged in and visiting without being redirected there.

Invites - frontend

Should be able to:

• add invitee
• delete invitee
• edit invitee? - not necessary
• basic styling
• validation

Error pages

Create error.hbs in views and layouts and use them to display error pages

eg https://github.com/foundersandcoders/express-handlebars-workshop/blob/solution/src/views/error.hbs

Test POST requests

http://visionmedia.github.io/superagent/

ladjs/supertest#168 (comment)

Editable groups

Groups should be editable by their owner once they've been created.

Include link from groups page to edit page for groups current user owns.

Date validation incorrect

Currently date validation claims "Date must have format yyyy-mm-dd but you entered".

• This is not the format the date is expected in
• and what the user entered is not displayed

Refactor tests

Separate each test into it's own file, and use test runners to link them up, like we did in https://github.com/FAC-11/AllAboutMe/tree/master/tests

Duplicate queryfile

Shouldnt be creating the same queryfile object multiple times (in backend.test and database.test.

Instead create both within db_build.js and export two functions using each sql file:

const path = require('path');
const dbConnection = require('./db_connection');
const { QueryFile } = require('pg-promise');

const seedFile = new QueryFile(path.join(__dirname, 'db_seed.sql'), { minify: true });
const buildFile = new QueryFile(path.join(__dirname, 'db_build.sql'), { minify: true });

const build = queryFile => dbConnection.any(queryFile)
  .then(() => {
    console.log('Database build successful.');
  });

/* istanbul ignore if */
if (require.main === module) {
  let file;
  if (process.argv[2] === '--seed') {
    file = seedFile;
  } else {
    file = buildFile;
  }
  build(file)
    .catch(console.log);
}

module.exports = {
  build: build.bind(null, buildFile),
  seed: build.bind(null, seedFile),
};

Middleware to restrict pages

Look into whether I can create my own middleware to make certain pages only viewable by logged in users

Database queries for users

• insert new user
• get user id and password based on email

Use flash messages

Instead of adding error messages to the context object being sent to handlebars templates. This is more versatile and allows messages to be added on redirect. FAC-11/AllAboutMe#108

Use promises

To learn how.

Particularly in tests?

Set up eslint

Linting isn't currently set up, set up eslint with airbnb guide and remove linting issues it finds.

Secure session management

https://dzone.com/articles/securing-nodejs-managing-sessions-in-expressjs