dangerfarms/newcomers-guide

Newcomers Guide to Dangerfarms

This guide helps newcomers to get a grasp of the processes we use at Dangerfarms to develop awesome products.

newcomers-guide's Issues

Discuss "toggle" functions

Instead of...

...
                <div class="UserCard__PlusTickContainer" ng-if="toggleUserCallback">
                    <md-button class="UserCard__Tick zmdi zmdi-check"
                               ng-if="user.isAdded"
                               ng-click="toggleUserCallback(user)"
                               aria-label="Remove member">
                    </md-button>
                    <md-button class="UserCard__Plus zmdi zmdi-plus"
                               ng-if="!user.isAdded"
                               ng-click="toggleUserCallback(user)"
                               aria-label="Add member">
                    </md-button>
                </div>
...

we should write separate methods addUserCallback and removeUserCallback. This prevents the button state from going out of sync with the action performed. Also avoids if/else logic within the toggle function, two separate methods is more testable and robust.

Fix search that sometimes ruins the reading site

Change richqoutes plugin to callouts plugin

Also need to change

• Note occurances.
• css files

https://www.npmjs.com/package/gitbook-plugin-callouts

Permalinks are broken

Everything is linking to /#undefined when you click on the permalink icon