Comments (14)
Core maintainer of eslint-plugin-jest
here 👋
I personally really like this plugin and want to make sure it's well supported - it doesn't look like there's been activity though in 2 years.
I technically don't have the authority to do this but I'm pretty sure @SimenB wouldn't object to having ownership of this plugin transferred to @jest-community to sit alongside eslint-plugin-jest
and allow myself and others to help with the maintenance if that's something @dangreenisrael would be interested in.
Personally I'm also happy to have these rules live directly in eslint-plugin-jest
though there might be a strong technical reason for why that shouldn't happen.
I'm also happy to help with the ESLint v9 support - @jamiehaywood let me know if you're still interested in doing that, have questions, etc; otherwise I can also pick it up if you're too busy.
from eslint-plugin-jest-formatting.
I'm alive 🎉. I've heads down at a new job for the last few monhts.
from eslint-plugin-jest-formatting.
I know you work/worked with Dan. Do you know his status?
Alive but a father of young children (child?) so I think his availability has been (reasonably) limited. I'll try to track him down so we can figure out publishing and ownership/maintenance.
Feel free to tag me for a second reviewer. I am glad that people have found some utility here.
from eslint-plugin-jest-formatting.
so the workaround config for ESLint 9 is to create an object in your flat config:
import jestFormatting from 'eslint-plugin-jest-formatting'
export default [
...
{
files: jestFormatting.configs.recommended.overrides[0].files,
rules: jestFormatting.configs.recommended.overrides[0].rules,
plugins: {
"jest-formatting": jestFormatting,
},
}
]
from eslint-plugin-jest-formatting.
hi @G-Rath! thanks for tagging me. Would be keen to raise a PR add ESLint 9 support - couple of questions:
- Would v9 support PR come before or after migration into
eslint-plugin-jest
? - Has there been a reconsideration of this comment by @SimenB a couple of years ago? As I believe this is the reason that
eslint-plugin-jest-formatting
became its own plugin in the first place.
from eslint-plugin-jest-formatting.
I'm not sure of @dangreenisrael's status, but I can merge PRs if I have another reviewer approval. What I can't do is a release to npm.
@hockeybuggy or @ryanwilsonperkin I know you work/worked with Dan. Do you know his status?
@G-Rath @jamiehaywood I'd be happy to review and merge if you want to take a chance that it might not make it to npm. We can do this while the ownership/maintenance discussions play out.
from eslint-plugin-jest-formatting.
If @benkimpel can merge it, I can get it onto NPM.
from eslint-plugin-jest-formatting.
I'm thinking a good example for supporting flat config is eslint-plugin-jest
.
They have a createFlatConfig
and add a flat/
appendix to the exports containing flat config.
I'll raise a draft PR over the next couple of weeks to sketch out backward compatible flat config support
from eslint-plugin-jest-formatting.
Alive
Phew! Glad to hear it.
from eslint-plugin-jest-formatting.
Has there been a reconsideration of jest-community/eslint-plugin-jest#17 (comment) by @SimenB a couple of years ago? As I believe this is the reason that eslint-plugin-jest-formatting became its own plugin in the first place.
I haven't heard anything from him.
from eslint-plugin-jest-formatting.
@dangreenisrael glad to hear you're alive, and congrats (I hope 😄) on the new job!
Would v9 support PR come before or after migration into eslint-plugin-jest?
The order of operations shouldn't matter, so I say go for it.
I haven't heard anything from him.
I'll see if I can grab @SimenB for a chat, though it might take awhile so I would continue as you were in the meantime.
fwiw if this plugin does move the community, it would be ideal to switch to using GitHub Actions for CI (so that its one less SaaS to manage) and to use semantic-release
for automatically releasing (so we don't need direct access to the package on npm) - both are things we use in the other eslint plugins and that I'd be happy to help setup if you're happy to switch to them now.
from eslint-plugin-jest-formatting.
fwiw if this plugin does move the community, it would be ideal to switch to using GitHub Actions for CI (so that its one less SaaS to manage) and to use
semantic-release
for automatically releasing (so we don't need direct access to the package on npm) - both are things we use in the other eslint plugins and that I'd be happy to help setup if you're happy to switch to them now.
I think that'd be fine as it would make it easier for contributors to other eslint packages to be more comfortable in this one, whether it moves into the community or not.
from eslint-plugin-jest-formatting.
Related Issues (20)
- Support ESLint 8.x HOT 2
- [BUG] `src/something/tests.tsx` doesnt get looked at HOT 2
- Blank line before expect
- Node engines is very specific HOT 3
- [Rule] Newline before expect HOT 14
- [DOCS] Links are wrong in `docs/rules/padding-before-all.md` HOT 2
- Allow configurable test file pattern HOT 8
- Fix some weirdness with expression => expect => expression => expect HOT 11
- [BUG] TypeError when extend recommended config HOT 11
- [Rule Update] padding-around-expect-groups configuration/default HOT 4
- [BUG] Rules not properly marked as deprecated HOT 2
- [BUG] Property "overrides" is the wrong type HOT 11
- [BUG] GitHub releases are maybe broken HOT 5
- [BUG] undocumented rule: (padding-around-all) HOT 4
- [Rule] test name should be trimed HOT 9
- [Rule] Disable padding around todo test blocks HOT 6
- Support ESLint 7.x HOT 5
- [BUG] .nvmrc file needs an update HOT 6
- [BUG] `padding-around-expect-groups` wants space around `expect`s which are `await`ed HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-jest-formatting.