Giter Site home page Giter Site logo

Errors swallowed when using --eval about nesh HOT 4 CLOSED

jawj avatar jawj commented on September 22, 2024
Errors swallowed when using --eval

from nesh.

Comments (4)

ccheever avatar ccheever commented on September 22, 2024

vm.runInContext throws an Exception if it has an error while evaluating code passed to it.
I think something like this would mostly fix the problem you're describing:

nesh> ccheever@Charless-MBP:~/projects/nesh$git diff
diff --git a/src/plugins/eval.coffee b/src/plugins/eval.coffee
index bfddc76..cb28b50 100644
--- a/src/plugins/eval.coffee
+++ b/src/plugins/eval.coffee
@@ -12,8 +12,12 @@ exports.description = 'Evaluates code in the context of the REPL'
 exports.postStart = (context) ->
     {repl} = context
     if repl.opts.evalData
-        log.debug 'Evaluating code in the REPL'
-        if global is repl.context
-               vm.runInThisContext repl.opts.evalData
-        else
-               vm.runInContext repl.opts.evalData, repl.context
+        log.log 'Evaluating code in the REPL'
+        try
+          if global is repl.context
+               vm.runInThisContext repl.opts.evalData
+          else
+               vm.runInContext repl.opts.evalData, repl.context
+        catch e
+          log.error "Error in --eval-ed code:"
+          log.error e.stack

from nesh.

jawj avatar jawj commented on September 22, 2024

That's perfect, and thanks for the fast response. I guess one of us should submit a pull request with that code.

from nesh.

danielgtaylor avatar danielgtaylor commented on September 22, 2024

Take a look at the commit above - I've implemented this in a more generic way so that all plugin preStart and postStart errors are logged, including stack traces if possible.

from nesh.

jawj avatar jawj commented on September 22, 2024

Looks great — thanks.

from nesh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.