danieliser/edd-file-watermarking

Easy Digital Downloads - File Watermarking

This plugin allows you to add varios types of text based file modifications to your EDD store files. You can add a watermark to your zipped plugin files, such as inserting or search & replace with license key, customer ID, or custom text outputs.

Features

• Watermarking for EDD files
• Search & Replace for EDD files
• License Key insertion for EDD files
• Customer ID insertion for EDD files
• Custom text insertion for EDD files
• Hash license key insertion for EDD files for masking the license key in a way the user doesn't see the actual license key

edd-file-watermarking's Issues

Fatal error when saving settings for the first time

Installed, went to settings to create a new watermark.

Selected "Append to File", entered the file path, skipped "Search String", and set the value for the watermark.

Saving the settings resulted in:

[01-Aug-2024 13:37:57 UTC] PHP Fatal error: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, function "EDDFileWatermarking\sanitize_watermark_repeater_settings" not found or invalid function name in [path]/public_html/wp-includes/class-wp-hook.php:324
Stack trace:
#0 [path]/public_html/wp-includes/plugin.php(205): WP_Hook->apply_filters()
#1 [path]/public_html/wp-content/plugins/easy-digital-downloads-pro/includes/admin/settings/register-settings.php(369): apply_filters()
#2 [path]/public_html/wp-includes/class-wp-hook.php(326): edd_settings_sanitize()
#3 [path]/public_html/wp-includes/plugin.php(205): WP_Hook->apply_filters()
#4 [path]/public_html/wp-includes/formatting.php(5115): apply_filters()
#5 [path]/public_html/wp-includes/option.php(866): sanitize_option()
#6 [path]/public_html/wp-admin/options.php(344): update_option()
#7 {main}

Corrupt zip file after installing edd-watermark

I can't verify this yet however, here are the details:

1. Made a duplicate of live site to run locally using Local by Flywheel.
2. Installed EDD Watermark and activated.
3. Added the following settings:
4. Testing by switching to another user and downloading their purchase zip file.
5. Attempting to open using Unarchiver or Archive Utility on macOS Sonoma (latest) results in the following error:
6. Doing the same thing on the live site, where EDD Watermark ins't installed, allows download and unzip of working zip file.

Not sure if related to https://core.trac.wordpress.org/ticket/60398

Fatal error: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback

Steps to reproduce:

• Install extension via WP Admin > Plugins > Add New > Upload Plugin
• Activate extension.
• Naviagation to Downloads > Settings > Extensions > Watermarking.
• Add a new Watermark of type 'Add File', 'license.txt', blank, {license_key}
• Click 'Save Changes'.

Fatal error then shows:

Fatal error: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, function "EDDFileWatermarking\sanitize_watermark_repeater_settings" not found or invalid function name in /app/public/wp-includes/class-wp-hook.php on line 324