danny-burrows/img_to_txt

Small utility that converts images into ASCII or ANSI text.

img_to_txt's Issues

arg_parse.c: Support multiple files conversion

Hi, @danny-burrows.
This issue is for arg_parse.c file.

About suggestion

When I used the program, I ran the command below.

./img_to_txt -hw 100 01.jpg -hw 50 02.jpg

As you can guess, I just wanted to convert multiple files with different options separately.
But, the results generated by the program showed me that they have same spec (or scale) given by the very last option (in this case, -hw 50).

So, there is my suggestion I want you to consider.
Could I make a pull request about dealing with multiple files that have different options?

Expected changes

• Delete a -- detecting condition
• Reorganization the structure of arg_parse function

This is just a draft, so you don't have to take care of them deeply.

---

Thanks for reading, and I look forward to hearing from you.

header files - #ifndef macro names

Good day, @danny-burrows.

Don't you think that header's macro name is little long?
Now - #ifndef IMG_TO_TXT_ARG_H
In my opinion, IMG_TO_TXT_ part is not necessary and is difficult to classify headers.

So how about this format?
Suggestion - #ifndef ARG_H
In more detail, if a header named 'hello.h' is located in include/here, just express like this - #ifndef HERE_HELLO_H.

If you have any other idea, please let me hear your feedback.