dannymachal/devdmbootstrap3

Twitter Bootstrap 3 WordPress Starter Theme for Developers

devdmbootstrap3's Issues

Javascript Error when trying to use Bootstrap Carousel

I've run into issues using the Demo Markup from the Bootstrap 3.1.1 docs site.

"Uncaught TypeError: Cannot read property 'slice' of undefined" is the error i get once i reach the end of the carousel.

child theme usage: calls to devdmbootstrap3_main_content_width() fails

Hi.

I've childed the theme and I've copied index.php to my child dir. The page load stopped at the first call to devdmbootstrap3_main_content_width(). The last line of html looks like this:

 <div class="col-md-

With the debug flag on I see this

Fatal error: Call to undefined function devdmbootstrap3_main_content_width() in /var/www/hispec/blog/wp-content/themes/hispec/index.php on line 1

Footer NavBar Overlaps Bottom of Website

One small bug that I've found is that the bottom of the website is covered up by the Footer NavBar. I've worked around the issue, but wanted to get it posted here... Good job.

Undefined variables on compile

I'm continually getting a slew of undefined variable errors (on files I haven't edited/touched) on compile. At first I thought it was a problem with the compiler (WinLESS), so I switched to using Brackets, but it's the same issue.

I've gone through variables.less and it looks like everything there has been declared, so I'm at a loss.

Initial Impression

Hey

I just downloaded your Master zip.
It is nice to see that the Parent and Child in the same folder. Easy to copy them over to htdocs folder into my test site.
Activated the child theme.

The first thing I looked for were various page templates. I see there are none included. What about including some with comments so the user can easily adjust?
Noticed a left and right widget area. Adding some widget areas with comments to a function file inside the Child theme?

DevDmOptions.
What about adding in Remove page title? (Yep can easily be done through CSS)
Remove Page comments?
Showing how to add options to the options panel.
Custom page panel? To where the user can easily select left, right, left and right sidebar layout. Some info on how to add options to the custom page panel.

A few ideas on how to extend the theme! Looks like a very good start though!

Bootstrap menu widget doesn't save selected with a quote in the name

Love the theme.

I had a menu with a quote in the name and the Bootstrap menu widget doesn't want to save the selection.

It works fine for my other menus.

I disabled all plugins and still get the issue.

I use v.1.40 of the theme.

Update to Bootstrap 3.1.1

Would be good to update to the latest version (v3.1.1).

PHP if statements don't quite line up in template-part-head.php

I was looking closely at template-part-head.php. The 'if' statements are lined up odd. I think if you had neither a header image or a header text color, you'd end up with mismatched html opening and closing div's. (I think you'd have one extra closing div in the mix.)

I think you want:

<?php global $dm_settings; ?>
<?php if ($dm_settings['show_header'] != 0) : ?>
<div class="row dmbs-header">
    <?php if ( get_header_image() != '' || get_header_textcolor() != 'blank') : ?>
        <?php if ( get_header_image() != '' ) : ?>
            <div class="col-md-4 dmbs-header-img text-center">
                <a href="<?php echo esc_url( home_url( '/' ) ); ?>"><img src="<?php header_image(); ?>" height="<?php echo get_custom_header()->height; ?>" width="<?php echo get_custom_header()->width; ?>" alt="" /></a>
            </div>
        <?php endif; ?>
        <div class="col-md-8 dmbs-header-text">
        <?php if ( get_header_textcolor() != 'blank' ) : ?>
            <h1><a class="custom-header-text-color" href="<?php echo esc_url( home_url( '/' ) ); ?>"><?php bloginfo( 'name' ); ?></a></h1>
            <h4 class="custom-header-text-color"><?php bloginfo( 'description' ); ?></h4>
        </div>
        <?php endif; ?>
    <?php else : ?>
        <div class="col-md-12 dbms-header-text">
                <h1><a href="<?php echo esc_url( home_url( '/' ) ); ?>"><?php bloginfo( 'name' ); ?></a></h1>
                <h4><?php bloginfo( 'description' ); ?></h4>
        </div>
    <?php endif; ?>
</div>
<?php endif; ?>

Not sure about the col-md-12 setting but you get the idea.