danoan/maglac

Create combinations of multiple types and lazy iteration using multiple threads

👋 Hi there, my name is Daniel

maglac's Issues

Several sets inneficiency

The Range class is recursive. The highest order Range is created from calling addRange from the second-highest range. For example

auto r = addRange( {1,2,3},2 ).addRange( {4,5,6},1 ).addRange( {7,8,9,10},2 );

Every range has a member variable previous, which is not stored as a reference. The problem is that every time addRange is called, the constructor of Range creates a copy of PreviousRange, and a cascade of copies is executed.

  template<class TIteratorNext>
  Range<TIteratorNext, TIteratorMaster, TIteratorSecond, TIterators...>
  addRange(TIteratorNext begin, TIteratorNext end, size_t elemsPerComb) {
    return Range<TIteratorNext, TIteratorMaster, TIteratorSecond, TIterators...>(*this, begin, end, elemsPerComb);
  }


 public:
  size_t elemsPerComb;
  size_t length;

  PreviousRange previous;

On the other hand, we cannot store previous as a reference due to the way ranges are created.