danvy/kloutsharp

Unofficial Klout client API in C#

Hi there 👋

What a blast ! I just launched Altoviz a smart and affordable invoicing and accounting app for small businesses and freelancers. Stay tuned.

Contacts

Skills

kloutsharp's Issues

Inefficient Http Client Usage

KloutSharp is generally great, however I believe there is some inefficient usage of System.Net.HttpClient. Issues include;

• Cannot inject an instance of HttpClient (or factory), so cannot apply modifying libaries such as https://github.com/paulcbetts/ModernHttpClient or https://github.com/paulcbetts/Fusillade
• A new HttpClient instance is created for each call. HttpClient is designed to be re-used, with an internal connection pool (https://msdn.microsoft.com/en-us/library/system.net.http.httpclient(v=vs.110).aspx) being maintained to improve performance. Creating a new client each time defeats the connection pooling.
• HttpClient instances are not disposed, therefore potentially, temporarily, leaking the pooled connections until garbage collection.
• GZip compression is not enabled by default on platforms that support it.
• The library does not use ConfigureAwait(false) on async calls, even though it does not appear to require any sort of thread affinity within the library. This adds a little overhead to each async call.

Null/Empty Key Handling

Just noticed while browsing the source that the Klout class allows construction with a null or blank key, but will then throw an KloutException when any of the methods are called. It also appears the only way to set the key is via the constructor, so you can't fix the problem after the instance is created.

Have I missed something? While it would be a breaking change at this point, would it not be better to throw an Argument or ArgumentNull exception from the constructor on an invalid key, rather than throwing a KloutException sometime later when it's all too late anyway?

Can't Use from UWP Project

Hi,

It seems the Nuget published version can't be used from a UWP project. The nuget package installs, but no namespaces or classes show up. Obviously I can work around this by including the source or making my own fork etc, but I would prefer to use the officlal nuget package to make future updates etc easy. Is there any possibility of a published update that supports UWP projects?

Thanks.