darshit-shah/smartfilter

smartfilter's Issues

Caching result does not consider order of values

When you add filter condition Qtr in [ "Q1" , "Q2" ], it will make query to database and cache result with this filter condition.
Now next time when you say Qtr in [ "Q2" , "Q1" ], because of change in sequence, it doesn't understand that filter condition is matching with older one.

In case of altering filter condition, both results, i.e. for original filter condition and for altered filter condition, should get cached

1. Lets say we added a filter Qtr in [ "Q1", "Q2" ], first time it will fire a query and store result in memory
2. Now apply filter condition Qtr in [ "Q1", "Q2", "Q3" ], now it will compare it with last condition and fire query only for only "Q3" and merge new result with previous result.
   Now in this case both results, i.e. new results for only Q3 and merged result for Q1, Q2 and Q3 should be cached. Right now only new result is getting cached.

Checking existing result in memory should also be done before altering query

1. Lets say we added a filter Qtr in [ "Q1", "Q2" ], first time it will fire a query and store result in memory
2. Now apply filter condition Qtr in [ "Q1", "Q2", "Q3" ], now it will compare it with last condition and fire query only for only "Q3" and merge new result with previous result.
3. Now apply filter condition Qtr in [ "Q1", "Q2" ], Here it starts comparing this condition with last condition and takes appropriate action. Instead first it should try to find result from existing results.