dartlangfr/ng-darrrt-codelab

Learn how to build a webapp with Angular.Dart in one hour.

This codelab is now maintained by the Angular Team:

angular/ng-darrrt-codelab

ng-darrrt-codelab's Issues

Write instructions for step 8-filter

Step 9 fails on pub build

Tracking bug. Related to https://code.google.com/p/dart/issues/detail?id=16462

Finish to write README.md introduction

Update links to the steps
Create an anonymous feedback form
Move "What is Angular?" section in step-1 Run the skeleton app

Add unit-tests by final step

Simplify the directive at step 7

ShadowDom problem on FF with AngularDart

From: https://code.google.com/p/dart/issues/detail?id=16403

(blois)- appears that the ShadowDOM polyfill is not included by default.

Reported by alexandre.ardhuin, Yesterday (21 hours ago)
Trying to run https://github.com/dartlangfr/ng-darrrt-codelab/tree/master/web/4-extractcomponent/piratebadge.html in Js I get the following error on Firefox 26.0 / Linux:

Error: TypeError: receiver.webkitCreateShadowRoot is undefined

The problem appears when I use a @NgComponent.

I'm on Dart Editor version 1.2.0.dev_01_00 (DEV) and you can find my pubspec.lock attached.

Write instructions for step 7-directive

Write instructions for step 9-cloak

Write instructions for step 6-piratebadge_json

Redirect people to angular/ng-darrrt-codelab

Hi @ggirou, @a14n, et al—

Would it be possible to retire this site, and instead refer people to https://github.com/angular/ng-darrrt-codelab/blob/master/README.md#code-lab-angulardart?

I apologize for kind of sideswiping your site. (We didn't anticipate that, but we were in such a hurry that we had to fork.) You are, of course, very welcome to contribute to the angular fork of this site, although please wait for Shailen's redo of the samples to land. (You can see his changes here: https://github.com/angular/ng-darrrt-codelab/tree/revamp.)

Please let me know how you'd like to proceed. Also... Did you get any interesting results from your survey? I'd love to know your traffic #s too. (I don't have access to https://github.com/dartlangfr/ng-darrrt-codelab/graphs/traffic.)

Thanks very much for all your help with introducing developers to AngularDart!

Write instructions for step 4-classbadge

Check all path given in the explaination

All path must be relative to working directory.

Write some tests ?

The angular tutorial contains some tests. What do you think about adding some tests to this codelab ?

Write instructions for step 3b-extractcomponent

Write instructions for step 4-classbadge

Renumber steps

Renumber 3a to 3, 3b to 4 and 4 to 5

Write instructions for step 2-inputnamebadge

Add mirrorsused in all your code

Hi,

To get the code size down, please add this to all of your entry points:

@MirrorsUsed(override: '*')
import 'dart:mirrors';

We will go do the same for our tutorial.

(This should go whereever main() is)

Thanks!

Add "Problems" section on each step

Problems?

Check your code against the files in 2-inputbadge.

• piratebadge.html
• piratebadge.dart

Write instructions for step 7-directive

Step 7-directive: the RockAndRoll directive

Step numbers don't match with the right directories

As in darrrt codelab, the result of a step correspond to the directory with the same number:

• Step 1: Run the skeleton app to 1-blankbadge
• Step 2: Add an input field to 2-inputnamebadge
• etc.

There is no development in step 1, just review code and launch the app. We could copy/paste or reference the step 1 of darrrt codelab, and add the review of angular dependency in pubspec.yaml for our step 1.

Missing code in 3a-buttonbadge

In piratebadge.html: ng-disabled="ctrl.name.trim().isNotEmpty"

Add final step for building and testing in non-Dartium browsers

Can you add a final step for how to build the app and open in Firefox, safari, etc ?

Thanks!

Write instructions for step 1-blankbadge

Copy/Paste of Step 1: Run the skeleton app
And explanation of angular dependency in pubspec.yaml

Write instructions for step 3a-buttonbadge

Simplify Step 5

Can we simplify and not use getters and setters from PirateName to the controller fields?

class BadgesController {
  // ...
  String get name => _name._firstName;
  set name(String value) {
    _name = new PirateName(firstName: value);
  }

  String get pirateName => _name.pirateName;
  // ...
}

could just be:

class BadgesController {
  PirateName pirateName;
}

The version in the code lab looks too verbose :(

Thoughts?

Rename component publishAs to cmp

I have a suggestion, just for clarity sake (particularly anyone viewing this without a presenter). Particularly in Step 4, consider rename the component's scope to cmp (short for component) instead of using ctrl (controller) to make it clear that the moustache bindings in badge_component.html are referring to the BadgeComponent class and not the BadgesController.