dascritch/anchors-reveal

Indicate anchors in a web page

anchors-reveal's Issues

i18n

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Internationalization

Refactoring code

Via e-mail :

A reviewer sent a message regarding the review of version 1.0 of add-on Anchors reveal.

erosman wrote:

Please note the following for the next update:

1. For inserting text, textContent (or JQuery text) or createTextNode() should be used instead of innerHTML.
   eg:
   legends[0].innerHTML = browser.i18n.getMessage('themeParameterDescription');

2. Add-on contains duplicate/hidden/unused/unnecessary files or folders. These complicate the review process and may contain sensitive information about the system you created the XPI on. Such files may also create cause for rejection. Please correct your packaging process so that these files aren't included.
   e.g.:
   lib.js

If you want to respond please reply to this email or visit https://addons.mozilla.org/en-US/developers/addon/anchors-reveal/versions

You are receiving this email because you are an author of this add-on.

Moving to WebExtension

visibility detection: false negatives

First of all, thank you for this add-on! I've found a bug, and I think it's quite easy to fix.

Steps to reproduce:

• Install Anchors Reveal (AR) v0.4.1
• Go to https://www.debian.org/distrib/packages
• Press AR's button

What happens:

Mainly the form fields are marked by AR.

What should happen:

The headings should be marked as well.

---

Currently AR does these checks on each element having an ID:

    function(el) {
      if (
          (el.id.indexOf(prefix)!==0) // not generated by the addon ?
          && ( valid_id.test(el.id) ) // not malicious ?
          && (!el.hidden) && (el.style.display !== 'none') // visible ?
          && ( (el.clientWidth != 0) && (el.clientHeight != 0 ) ) // really visible ?
        ) {

In this case all tests evaluate to true, but clientWidth and clientHeight are false.

I did some research and it looks like it's better to use offsetWidth and offsetHeight. JQuery additionally uses getClientRects().length, see jquery's code:

jQuery.expr.filters.visible = function( elem ) {
    return !!( elem.offsetWidth || elem.offsetHeight || elem.getClientRects().length );
};

You might want to take that expression instead of the current ones. You could also remove usage of el.hidden and el.style.display.

MDN documentation: HTMLElement.offsetWidth, HTMLElement.offsetHeight, Element.getClientRects().

Inline elements not displayed

I've got a big issue if the element is inline. As in Wikipedia.
For GitHub, sorry but their improperly use of name="" should be ashamed

New translations wanted

Le locales are there : https://github.com/dascritch/anchors-reveal/tree/master/_locales

Spelling oopses

License name in README.md:
Purpose -> Public

In the AMO description:
clic -> click

Also the AMO description could be a little more elaborate, non-web developers might not know exactly what an anchor is.

Changing aspect of the tags

See addons reviews #874609/ :

One click shows the anchor, another click hides them. Very simple! But please, add an option to customize how it is shown. This yellow colour is too aggressive for me.

Yes, it is right. But we have a very simple addon (I bet on minimal functionality).
Perhaps I do some (home) works to build a simple preference page

Context menu entry is non-functional right after installation

After installation of v1.0 from AMO and enabling the contextual menu I do get the menu but nothing is happening when selecting it. The menubar icon button do work however.

I see no output on the javascript console when selecting it either.

Github's anchors aren't corrects

The issue is longely known
github/markup#349 (comment)

A patch is proposed
gjtorikian/html-pipeline#136
gjtorikian/html-pipeline#135

I don't know if they will accept it :/

Moving to WebComponent

Mainly because shadowDOM is not style contaminated by host page

Do not display id for hidden elements

No use to show the anchor of a empty or undisplayed element. Especially when hotlinking a document.

Add short-key (parametrable)

Anchors-reveal should be able to be invoked via a shortkey. The sequence must be parametrable because of the number of potential addons.

Refresh on resize

If the user is resizing its viewport (resizing window of orientation device), tags ID aren't moving accordingly.
The script should redraw/recalc on this event.

Refresh on mutations

If the page is modifying its aspect (DOM mutation or CSS property), tags ID aren't moving accordingly.
The script should redraw/recalc on this event.

Do not show id on top

If element is positionned at top:0 and left:0 of the document, it should not be shown.

Filtrer l'attribut

Add sidebar

Add a sidebar with the anchors lists (linked to the anchor)

Original logo in SVG

Actual button logo is a borrowing from the default KDE theme Oxygen by the Oxygen Team .

It will be useful to have a more original one, and in svg to not doing stupidful verbose declarations.
Do you remember <link rel="apple-touch-icon"… > ?

Doing a builder for both Firefox and Chrome addons

https://developer.chrome.com/extensions/getstarted

[Context Menu] item position in list

i use 'translate selected' from the menu, so it would be good to move this item to bottom