dashpay/proposal-generator

Dash Client-Side Governance Proposal Generator

Dash Proposal Generator

Get Started

Before being able to use this repository, you will need to build the @dashevo/dashcore-lib for browser which is a required dependency. This can be done easily by running:

npm install
npm run build

You will find in the vendor folder the file index.js which index.html reference. This file handle a browserified version of @dashevo/dashcore-lib aswell as some inner logic that you can find in "js/index.js".

Dockerized

A Dockerfile has been included in order to build the site deterministically, as well as a script to run the Docker site build, and place the resulting artifacts in the dist/ directory. To run the full Dockerized build, run this script:

bash scripts/build.sh

proposal-generator's Issues

start_epoch, end_epoch and payment_amount should be numbers, not strings

Lots of errors in console in Safari

This is just a few seconds after page finished loading:

And it keeps growing really fast.

As far as I can tell it's Safari only issue, works fine in Firefox for me.

Simplify the work workflow

Hi, currently the proposal generator tries to do too much and effectively doesn't work anyway once you put in the hash from the prepare statement. What the site tries to do is force the user to wait for 6 confs (after you paste the hash into the site) then I suppose it gives you final string to submit in the wallet. This is all awkward stuff and unnecessary stuffing about. All this proposal generator is good for is coming up with the gobject prepare .... statement based on the user's input and site's validation on the initial screen. Once it gives you the blob, the user will drop it in their core wallet console and the fee is paid hooking the proposal on chain, after that it only takes ONE conf to be valid and the next step the user should do is alter the original blob and replace the word prepare with submit and append the TX hash they got from the console and shove it back into the console.

It makes no sense to continue this flow in the proposal generator, instead the page which currently requests you input the TX hash should instead take that TX and immediately formulate the second command, eg gobject submit .....TX-hash and advise the user to paste it into the console when they have one confirmation on their previous TX, That's it ! There's nothing more to it. The proposal generator does not need to follow the chain and count 6 confs and validate the transaction hash, all of that is nonsense, the user just needs to be able to count 1 and wait a few minutes. Simplify this page, thus making it work better.

trim input fields before calls to BitcoinJS

add source link to page footer

Since this is a high(ish) profile site used by the Dash community, I'm almost certain that a link to the source will be appreciated.

Serious flaw in the payment date calculator

It is calculating superblock dates wrong right now and may set people up for failure.

improve documentation

Needs better title/description, what the app does and in this case, live app URL, as well as Travis-CI build badge

create a real test suite

Currently the Travis-CI test suite is simply "true", although the build will fail if the npm install or build process breaks.

feat: P2SH payouts after Core v18

Dash Core v18 will enable payouts to P2SH addresses (e.g. multisig). Currently, the proposal generator has validation on the address field to (correctly) prevent such addresses as being considered valid. Once v18 is live and the DIP24 fork activates, the restriction should also be lifted in the proposal generator.