Question concerning Pull Requests

[kristi-sara]

Question concerning Pull Requests

[mikemahoney218]

My personal rule of thumb is that if the things you're addressing are similar to each other -- for instance, the same error is made in two places, or a new version of a package means that several functions need to be updated -- then it's perfectly fine to put those together into one PR. But if the changes aren't really related -- so, one function needs to get updated to a new version and one paragraph is too confusing -- I think it's best to submit those as separate PRs.

Obviously that's not the most cut and dry answer! In the absolute worst case scenario, you might get asked to split a PR into two so that we can merge any obviously-correct changes while keeping conversation going on any less-obvious improvements. But I think it works as a rule of thumb 😄

[drakeasberry]

Thanks @kristi-sara for the question and to @mikemahoney218 for a very good explanation. This has worked well for us in the past:

1. One PR per issue per lesson when issues are unrelated or substantial changes are being made are being made to any given lesson.

2. One PR across multiple lessons addressing the same issue such as typos or changes to packages needed to run the episode.

Note: some changes necessitate multiple changes throughout a lesson to make sure everything stays in-sync. If you find this to be the case, it would be better to separate into different PRs.

Thank you for contributing and please feel free to reach out anytime.

[kristi-sara]

Thank you @drakeasberry and @mikemahoney218. I will add some requests as noted, thank you for the clarification.