Giter Site home page Giter Site logo

node-eventbrite's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

node-eventbrite's Issues

Error handling threw unhandled error

Date: Fri Aug 01 2014 20:35:19 GMT+0000 (UTC)

Source:Node process uncaughtException

Message: Cannot read property 'description' of undefined

Stack: TypeError: Cannot read property 'description' of undefined
at Object.module.exports.createEventbriteError (/home/ubuntu/www/node_modules/node-eventbrite/lib/eventbrite/helpers.js:49:30)
at Request._callback (/home/ubuntu/www/node_modules/node-eventbrite/lib/eventbrite/eventbrite_v3.js:87:33)
at Request.self.callback (/home/ubuntu/www/node_modules/request/request.js:121:22)
at Request.emit (events.js:98:17)
at Request. (/home/ubuntu/www/node_modules/request/request.js:985:14)
at Request.emit (events.js:117:20)
at IncomingMessage. (/home/ubuntu/www/node_modules/request/request.js:936:12)
at IncomingMessage.emit (events.js:117:20)
at _stream_readable.js:929:16
at /home/ubuntu/www/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:177:31
at process._tickCallback (node.js:419:13)

Problem in error handling

Hi,

I think there's a problem when receiving an error from the Eventbrite API - in the code for handling the response (starting in line 106 of eventbrite_v3.js).

Once parsedResponse.error results in true the error retuned to the callback is (line 110):
callback(new Error(parsedResponse.error + '' + parsedResponse.error_description))

while I think it should have been:
return callback(helpers.createEventbriteError(parsedResponse));

This last line actually appears in line 117 but seems to never be called (unless I'm missing something).
The first callback returns a "message" only error object that doesn't hold the http response code or description separately.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.