dattatreya303/round_robin_tasker

A telegram bot for groups to assign a task to members in a round robin manner

round_robin_tasker's Issues

Add persistence to conversation handler

To make a conversationhandler persistent (save states between bot restarts) ConversationHandler(<no change>, persistent=True, name='my_name') If you want a conversationhandler to be persistent you MUST NAME IT. persistent is False by default. Adding these arguments and adding the conversationhandler to a persistence-aware updater/dispatcher will make it persistent.

Handle commands interrupting a conversation

Problem: Updates get checked through the handlers sequentially. So if a user, while in the midst of a conversation, sends a command which is processed before the concerned conversation handler by the dispatcher, it messes up the conversation (especially if its another conversation).

Possible fixes:

1. Maintain a var in context.chat_data to identify any ongoing conversation. Check that var at the beginning of all command entry point callbacks. Proceed only if the var is empty.
2. Maintain a var in context.chat_data to identify any ongoing conversation. Add a top-level nested conversation handler. the entry point should be any message, the timeout should be infinite, states should correspond to actual user commands. Make the entry point a command handler. First, perform the check for an ongoing conversation and if found return that state. If no ongoing conversation, return the state corresponding to the command (over a switch case preferably).
3. Maintain a global var to identify any ongoing conversation. Send all updates to that handler only. Will require changes in the library. We will have to use a fork of the library with our changes, and not download from pip. Will need to create a separate build script.

Decentralise logging

A single log handler is being used right now, which belies source (class: function) of the log. Separate log handlers for each file/class would give more comprehensive information.

Ensure backwards compatibility with current file-based chat data store

Add basic persistence for task data of each chat

Migrate task data when a group is promoted to supergroup

https://github.com/python-telegram-bot/python-telegram-bot/wiki/Storing-bot,-user-and-chat-related-data#chatmigrated-errors

Don't handle this now. Adding persistence will change data storage API. Take care of this after persistence is solved (#5, #1) .

Add support for conversation chat flow

https://python-telegram-bot.readthedocs.io/en/latest/telegram.ext.conversationhandler.html

https://github.com/python-telegram-bot/python-telegram-bot/blob/master/examples/conversationbot.py

Add jenkins integration for continuous deployment

Add /list-tasks command

Missing chat id checks on chat data context

Key checks are missing for chat id in context.chat_data in several places. This is leading to KeyErrors when starting the server or sending a command in a chat with no associated ChatData object.

Add unit testing

• Make test cases for each issue labelled with feature and bug.
• Make it a norm to write test cases first for all future features and bugs.

Add /start command callback method

• Introduce the bot and what it does.
• Mention the test bot for experimental features
• Show the list of commands and brief instructions
• Mention telegram id for feedback

Implement scheduled/current downtime notifier

Unsupported commands are not being handled in the root handler

Unsupported commands are not being handled in the root handler callback. Throwing KeyError in the switcher dict.

Migrate from jenkins to circleci

Alternative: Host Jenkins in a public server. CircleCI seems much simpler though.

Add mysql persistence for all data

Add delete-task(s) command

Do cleanup after process kill signals

Unset ongoing conversation flag for all chats.

Implement scheduled reminders for tasks

Set up different environments for test and prod

This will probably require a different authentication token for test environment.

Restrict edit access of bot to chat admin only

Update README

The first part should be same as #13 .
Add more details about repo structure, deployment process, persistence, todos etc

Handle secrets, passwords, credentials using a secrets management tool

Explore Vault (By Hashicorp), Azure Key Vault etc
https://dzone.com/articles/top-secrets-management-tools-compared