Comments (12)
Subscribing here to see if there's any progress on your side. We have trouble porting jABCI to 0.15+ tendermint because of those new gogoproto types.
jTendermint/jabci#34
from py-abci.
I'm currently trying out a more streamlined rebuild with ideas from the links you gave, @sbellem.
Looks promising so far.
What I'm doing is having the gogo.proto from the gogo repo next to the tendermint types proto and do some java options. I'm using the protoc maven plugin and say that it has to include stdTypes (the ones from google) as they are imported from gogo.proto.
This leads to generated files for tendermint.abci and gogoproto which seems to work. Currently still in testing but this looks good. (with the minor caveat that the CodeType type has vanished, nothing a constant class wont fix ;) )
from py-abci.
@sbellem Yes unfortunately I'm currently knee deep in Go programming on Ethereum. So any help you can provide is greatly appreciated!
from py-abci.
Should be resolved with the latest merges thanks to @sbellem. Leaving open for now until we test more.
from py-abci.
So if I'm understanding correctly, this is a fundamental problem with the latest types.proto file in tendermint?
from py-abci.
So if I'm understanding correctly, this is a fundamental problem with the latest types.proto file in tendermint?
Well, since I am not very knowledgeable with protobuf I wish to be careful to make conclusions, but it most certainly complicates things.
I am currently testing the simple approach of removing the annotations, and will report as soon as possible.
from py-abci.
At first glance, it looks like you need to add gogo protobuf to your build chain to properly compile it for Python bindings - but this is a very quick assessment. Here's an example:
https://github.com/bblfsh/client-python/blob/master/setup.py#L86
from py-abci.
Oh, interesting. I have tried using gogoprotobuf, following https://github.com/gogo/protobuf#more-speed-and-more-generated-code but ran into the import problem, reported in cockroachdb/cockroach#393:
FYI, the python-specific issue here is that protoc's python support assumes that the proto directory structure and python package structure are the same: importing github.com/gogo/protobuf/gogoproto/gogo.proto in a proto file translates to "import github.com.gogo.protobuf.gogoproto.gogo_pb2" in python. Using "github" as a top-level python package is basically a non-starter. Even if this were fixed and the top-level package remapped to "gogoproto", someone would need to own the "gogoproto" python package; there's no clean way for cockroach-python to distribute its own vendored version of gogoproto.
I could try the approach used in the link you provided.
In the meantime, the approach of removing the annotation yields positive results, but as pointed out by @srmo it does not mean that there cannot be unnoticed negative side effects.
from py-abci.
@davebryson just made a PR to show the naive approach of removing the annotations. You can consult the description of the PR for additional details.
I will resume work on this issue tomorrow. I am ok with helping resolving the issue, so please let me know if you prefer to tackle it yourself, or how I can help.
from py-abci.
@davebryson ah ok, that's fine! Thanks for letting me know!
So I'll take care of the issue then. Will keep you informed via this issue and PR #11 as progress is made..
from py-abci.
At first glance, it looks like you need to add gogo protobuf to your build chain to properly compile it for Python bindings - but this is a very quick assessment. Here's an example:
https://github.com/bblfsh/client-python/blob/master/setup.py#L86
@davebryson see PR #14
from py-abci.
Closing for now. See abci-0.10.0 branch
from py-abci.
Related Issues (20)
- [packaging] When should the proto files be compiled? HOT 3
- Push new pypi release HOT 1
- What's the status of this project? HOT 7
- Latest version of ABCI uses int64 vs bigendian HOT 1
- Got an error while sending transaction to example app
- Error parsing message HOT 5
- Need to update tag and pip
- tm-bench gives zero Txs/sec against the counter.py example HOT 3
- Getting "Rejected bad transaction" when doing a transaction
- ModuleNotFoundError: No module named 'protobuf'
- How to send binary data transactions HOT 3
- abcisocket is failing to connect HOT 3
- branch for tendermint 0.31.5 HOT 2
- tendermint v0.34 HOT 1
- ABCIServer.run() raises an `AttributeError` HOT 4
- google.protobuf.message.DecodeError: Truncated message. HOT 2
- Gevent fails on Windows HOT 1
- Update python setup
- CTRL-C signals fail on windows
- need to re-export *all* abci types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from py-abci.