davidchristiansen/dotnetopenauth.webapi

DotNetOpenAuth for ASP.NET WebAPI (OpenID/OAuth/OAuth2)

dotnetopenauth.webapi's Issues

Problems with Visual Studio 2013

I tried to open the project in Visual Studio 2013 and it did not go well. I see errors like:

packages\Microsoft.Bcl.Build.1.0.7\tools\Microsoft.Bcl.Build.targets was not found

I believe that the issues relate to this:

http://blogs.msdn.com/b/dotnet/archive/2013/06/12/nuget-package-restore-issues.aspx

Don't use HttpContext.Current

Using HttpContext.Current is gennerally considered a bad thing for several reasons like mocking and testability.

The following has proven to be working as an alternative: https://gist.github.com/3194281

Hack to force string-comparisons to be done case-sensitivily.

I've read (parts of) your code, and I noticed the commend about case-sensetive checking only beeing to set in the db, however, I though I'd show you this little technique I use to achive the same with minimal overhead:

        CryptoKey ICryptoKeyStore.GetKey(string bucket, string handle)
        {
            // It is critical that this lookup be case-sensitive, which can only be configured at the database.
            var _db = SymetricCryptoKeys.Where(k => k.Bucket == bucket && k.Handle == handle).ToList();
            var matches = from key in _db // hack to make case-sensitive
                          where key.Bucket == bucket && key.Handle == handle
                          select new CryptoKey(key.Secret, key.ExpiresUtc.AsUtc());
            return matches.FirstOrDefault();
        }

Notice that the last itteration is done on in-memory objects, thus the comparison is done in C#, not in the db.