davidepedranz/go-hole

Fast DNS sinkhole that blocks domains known to serve ads and other unwanted content.

go-hole's Issues

Disable Prometheus by default

• Enable Prometheus only if the user defines PROMETHEUS_PORT (and maybe not to an empty string)
• Allow to defined the network to listen to too --> PROMETHEUS_ADDR

Panic after IndexOutBound

go-hole/dns.go

Line 166 in 1ee134d

expiration := time.Duration(res.Answer[0].Header().Ttl) * time.Second

Must check if any response exists before caching it.

Lists

Consider:
http://pgl.yoyo.org/adservers/serverlist.php?hostformat=nohtml&showintro=0&mimetype=plaintext

Remove twitter link shortener

(t.co) This completely breaks the app, and "track" only if you click.

Update dependencies

Dependencies are a bit outdated. This is a reminder to update them ;-)

Documentation

Hey Davide
After stumbling on yet another pi-hole praise on the internet, I gave it more thought, and said to myself:

wouldn't it be great to have this, only in an a-priori better suited language than bash, like go? (wild guess)
And as a bonus, the resulting all-in-one binary could be dropped as-is instead of this docker thing I just don't care to install on my gentoo system.

I Googled for it and tadaa! found go-hole.
Sure enough, a -brilliant- guy thought about this before me (and had the knowledge, which accidentally I don't have)... !
So: I like your idea, and thank you for making it open source!

TL;DR:

I did not try go-hole yet. But from the readme, I still lack some info:

• are you pursuing developpement on this project? Sorry if this sounds abrupt.
• where can the DNS resolver be set? (you state 1.1.1.1 is the default: where do we change that?)
• do you have a quick setup to make it work hand in hand with dnscrypt-proxy? (I think that would be a good idea to match them?)
• can we control cache duration?