davidgomes/bs-luxon

Luxon bindings for Bucklescript/ReasonML

bs-luxon's Issues

Publish 0.3.0

It doesn't appear to have been published to npm

Upgrade Luxon to `1.x.x`

Upgrade to the 1.x.x major version. They update pretty frequently, but doing minor bumps after the major upgrade wouldn't need much work when someone needed/wanted it. The current version at the time of this issue is 1.9.0.

Just making a note of this- I may get around to tackling it soon™️.

Split Luxon.re into a few modules

Right now, bs-luxon clients have to use it like this:

let dt = BsLuxon.Luxon.DateTime.local();

Js.log(dt);

We should refactor DateTime into its own module so users can use it like this instead:

let dt = BsLuxon.DateTime.local();

Js.log(dt);

update README - open BsLuxon

Thanks for making bs-luxon! The front page has an example of using it:

DateTime.(
  local()
  |> setZone("America/New_York")
  |> minus(`Duration(Duration.from(~weeks=1, ())))
  |> endOf(`day)
  |> toISO()
);

I think this should have open BsLuxon; at the top, since that's what I needed to do in order to get it to compile; pointing this out for others that want to use the library. See here for an example of using it in a project.