davidiq/mailinglist

phpBB extension for adding basic mailing list functionality to boards so that new posts and/or topics can be forwarded to configured mailing list addresses and associated forums.

mailinglist's Issues

Development

Hi @DavidIQ,

is this extension is still in development ?

Image and video tags not coming through in emails

https://github.com/DavidIQ/MailingList/blob/master/event/listener.php#L123

Looks like the strip_tags call is completely stripping out images and videos so they don't come through at all in emails. Will need to investigate to see if maybe a regex can be devised to strip out the BBcodes and leave behind the URLs. Another possible solution would be to leverage the messenger class and override the text-only setting of the emails sent out by this extension.

Originated from: https://www.phpbb.com/customise/db/extension/mailinglist/support/topic/206856

Set "In-Reply-To" header

To help email clients keep messages together (threaded) set the "In-Reply-To" header as well as the "References" header. Should be enough to use the topic ID in some fashion for both to keep them grouped together.

Have a per-forum mailing list

Provide the ability to set a per-forum mailing list address instead of just a general mailing list setting.

Code review notes

• managers/mailinglist_manager.php

while ($row = $this->db->sql_fetchrow($result))
{
	$sql2 = "SELECT m.mailinglist_forum_id, f.forum_name
	   FROM {$this->mailinglists_forums_table} m
	   JOIN " . FORUMS_TABLE . " f ON f.forum_id = m.mailinglist_forum_id
	   WHERE m.mailinglist_id = {$row['mailinglist_id']}";
	$result2 = $this->db->sql_query($sql2);
	$row['forums'] = $this->db->sql_fetchrowset($result2);
	$this->db->sql_freeresult($result2);
	$mailinglists_data[$row['mailinglist_id']] = $row;
}

Line 72-82: please don't run database queries inside loops. You should run a single query, for example WHERE $db->sql_in_set('m.mailinglist_id', $mailinglist_ids)

foreach ($forum_ids as $forum_id)
{
	$sql = "INSERT INTO {$this->mailinglists_forums_table} " . $this->db->sql_build_array('INSERT',
			[
				'mailinglist_id' => $mailinglist_id,
				'mailinglist_forum_id' => $forum_id
			]);
	$this->db->sql_query($sql);
}

Line 199-208: rather than looping over the rows to insert, you should use $db->sql_multi_insert()

• migrations/v20x/add_mailinglist_table.php & v200.php
  Indentation could be improved in these files.