davidmeijer/python-intermediate-inflammation

A template software project for use in Intermediate Research Software Development Skills In Python course. Contact: @jag1g13

python-intermediate-inflammation's Issues

Add specification of which Python version

The repository currently doesn't list for what python version the project is built, consider adding this to README.

Test commented out

python-intermediate-inflammation/tests/test_models.py

Line 103 in 68472f2

# @pytest.mark.parametrize(

This test is currently commented out, consider uncommenting it or removing it.

Add a license

There is no license included in the repository.

Align pre-requisites in readme with requirements.txt

There are requirements listed in the Read.me file which are also in the file requirements.txt. Perhaps it's not needed to add requirements to the Read.me file if you have in requirements.txt? please check.

Lacking a standard deviation view

The inflammation analysis function is lacking the daily standard deviation analysis

python-intermediate-inflammation/inflammation_analysis.py

Lines 22 to 26 in 68472f2

	view_data = {
	'average': models.daily_mean(inflammation_data),
	'max': models.daily_max(inflammation_data),
	'min': models.daily_min(inflammation_data)
	}

Documentation missing for Observation class

python-intermediate-inflammation/inflammation/models.py

Lines 13 to 14 in 68472f2

	class Observation:
	def __init__(self, day, value):

Missing pyproject.toml file

Adding a pyproject.toml file should also address this issue #3

Missing docstring

python-intermediate-inflammation/inflammation/models.py

Line 13 in 68472f2

class Observation:

Unused code

The object oriented code in models.py is not being used in the controller or viewer (relates to #7 / #1 )